Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 16 Support #66

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Xcode 16 Support #66

merged 2 commits into from
Sep 10, 2024

Conversation

bmxav
Copy link
Contributor

@bmxav bmxav commented Sep 6, 2024

There were some issues parsing Objective-C build logs from the Xcode 16.0 Beta, so the XcodeLogParser has been reworked to address that. With these changes the parser will no longer attempt to backtrack while searching for build commands, so there is a significant performance increase as well.

@bmxav bmxav changed the title Xcode 16 Beta Support Xcode 16 Support Sep 6, 2024
Copy link
Collaborator

@NinjaLikesCheez NinjaLikesCheez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments. I've fixed the SwiftLint pipelines which should be merged before this: #67

Sources/GenIR/Extensions/String+Extension.swift Outdated Show resolved Hide resolved
Sources/GenIR/XcodeLogParser.swift Show resolved Hide resolved
@bmxav bmxav force-pushed the xcode16-fixes branch 2 times, most recently from ae2e961 to 40e7c6f Compare September 9, 2024 12:31
@bmxav bmxav merged commit 3525f46 into develop Sep 10, 2024
2 checks passed
@bmxav bmxav deleted the xcode16-fixes branch September 11, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants