Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Code scanning alerts #254

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix(api): Code scanning alerts #254

merged 1 commit into from
Nov 6, 2023

Conversation

pycook
Copy link
Collaborator

@pycook pycook commented Nov 6, 2023

No description provided.

@pycook pycook merged commit 863289b into master Nov 6, 2023
1 check passed
unique_key = locals()['AutoDiscovery']().unique_key
attrs = locals()['AutoDiscovery']().attributes() or []
local_ns = {}
exec(x, {}, local_ns)

Check failure

Code scanning / CodeQL

Code injection Critical

This code execution depends on a
user-provided value
.
This code execution depends on a
user-provided value
.
@@ -312,7 +313,7 @@
start = time.time()
execute = db.session.execute
# current_app.logger.debug(v_query_sql)
res = execute(v_query_sql).fetchall()
res = execute(text(v_query_sql)).fetchall()

Check failure

Code scanning / CodeQL

SQL query built from user-controlled sources High

This SQL query depends on a
user-provided value
.
This SQL query depends on a
user-provided value
.
This SQL query depends on a
user-provided value
.
This SQL query depends on a
user-provided value
.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
@@ -525,7 +526,7 @@
if k:
table_name = TableMap(attr=attr).table_name
query_sql = FACET_QUERY.format(table_name, self.query_sql, attr.id)
result = db.session.execute(query_sql).fetchall()
result = db.session.execute(text(query_sql)).fetchall()

Check failure

Code scanning / CodeQL

SQL query built from user-controlled sources High

This SQL query depends on a
user-provided value
.
This SQL query depends on a
user-provided value
.
This SQL query depends on a
user-provided value
.
This SQL query depends on a
user-provided value
.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
This SQL query depends on a user-provided value.
pycook added a commit that referenced this pull request Nov 7, 2023
@pycook pycook deleted the dev_api_1106 branch November 7, 2023 04:11
pycook added a commit that referenced this pull request Nov 7, 2023
pycook added a commit that referenced this pull request Dec 3, 2024
pycook added a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant