Make sure to use OrderBy before Take

This silences the warning about using a row limiting operator on an unordered data set.
veloek · Sep 5, 2024 · 6f0c15c · 6f0c15c
1 parent 8fb0af3
commit 6f0c15c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/Tevling/Data/DataContext.cs b/Tevling/Data/DataContext.cs
@@ -44,6 +44,10 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                 e => e.HasOne<Athlete>().WithMany().HasForeignKey(e => e.FolloweeId),
                 e => e.HasOne<Athlete>().WithMany().HasForeignKey(e => e.FollowerId));
 
+        modelBuilder.Entity<Athlete>()
+            .Property(a => a.Created)
+            .HasConversion(new DateTimeOffsetToBinaryConverter());
+
         modelBuilder.Entity<Challenge>()
             .HasOne(c => c.CreatedBy);
 

diff --git a/Tevling/Services/AthleteService.cs b/Tevling/Services/AthleteService.cs
@@ -219,6 +219,7 @@ public async Task<Athlete[]> GetSuggestedAthletesToFollowAsync(int athleteId, Ca
                         .Except(followedAthleteIds)
                         .Contains(a.Id) &&
                     a.Id != athleteId)
+            .OrderBy(a => a.Created)
             .Take(5)
             .ToArrayAsync(ct);