【確認待ち】5.9で蛍光マーカー再編集が出来るように調整 #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format-library-text-color-button__indicatorを削除 関連 : WordPress/gutenberg#34680
Closed
|
レビュー中 |
mthaichi
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.9で蛍光マーカーが再編集出来るように調整しました。
5.8と5.9ともに問題ないか確認お願いします。
関連：WordPress/gutenberg#21892
5.8と仕様が異なるのは、FormatToolbarのコンポーネントが変更され5.8までに存在していたテキスト色(
text-color)のフックが無くなったため、keyやnameでActiveな時のみツールバーに表示出来るようなフックは出来なくなりました。コアでもissuesが上がっているのでいずれフックが入るかもです。
issue WordPress/gutenberg#22663