Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colour/fill/stroke #2

Open
ijlyttle opened this issue Jun 15, 2019 · 1 comment
Open

colour/fill/stroke #2

ijlyttle opened this issue Jun 15, 2019 · 1 comment

Comments

@ijlyttle
Copy link
Contributor

Hi @wenyuyangpku, @haleyjeppson,

I know we discussed this a little bit during one of our meetings. Here's what I think I remember, so I will rely on you to "fill in the gaps":

In general, ggplot2 colour -> Vega-Lite stroke, and ggplot2 fill -> vega-lite fill.

In Vega-Lite, color can mean stroke or fill, depending on the type of mark.

I remember @haleyjeppson saying something about colour and fill having different meanings in ggplot2, depending on the context.

I'd like to use this issue as a way for us all to come to an agreement on how to navigate this.

@wenyuyangpku
Copy link
Contributor

For now, I just remove color and use stroke and fill to substitute it in Vega-Lite.

haleyjeppson added a commit that referenced this issue Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants