Fix edge cases: Use TRY_CAST for type conversions, convert cols to datetime before stringification #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the edge case of a string column being used in local datetime context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the TRY_CAST construct across SQL dialects and switches to using TRY_CAST for type conversions. This avoids crashes for things like Vega's
toNumeric("abc"), instead returning a NULL, which is much closer to Vega's behavior (it returns a NaN).Also adds an explicit
toDateto the local datetime stringification logic to handle edge cases where a string column is used in a local datetime context without conversion.