Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove default opacity if fillOpacity is set #9238

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: remove default opacity if fillOpacity is set #9238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4940a08
fix: remove default opacity if fillOpacity is set
ChiaLingWeng Jan 30, 2024
6e1723e
Merge branch 'vega:main' into clw/fillOpacity
ChiaLingWeng Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/compile/mark/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export function initMarkdef(originalMarkDef: MarkDef, encoding: Encoding<string>

// set opacity and filled if not specified in mark config
const specifiedOpacity = getMarkPropOrConfig('opacity', markDef, config);
if (specifiedOpacity === undefined) {
const specifiedfillOpacity = getMarkPropOrConfig('fillOpacity', markDef, config);
if (specifiedOpacity === undefined && specifiedfillOpacity === undefined) {
markDef.opacity = opacity(markDef.type, encoding);
}

Expand Down
Loading