fix: support discretizing scales for shape #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
force-pushed
the
dom/shape-discretizing
branch
from
b837970 to
3357451
Compare
domoritz
force-pushed
the
dom/shape-discretizing
branch
from
3357451 to
99bc5c4
Compare
kanitw
approved these changes
Jan 31, 2021
|
I consider this a bug fix rather than a "feat" since it doesn't really expand the schema for the syntax. |
domoritz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7167
In https://github.com/vega/vega-lite/pull/6201/files#diff-245098c24d290d1cd456956b3a74d688f56ec8a89e28ca9851ddd21067d8518aR828, we only allowed discretizing scales for stroke dash. This pull request also enables support for shape.