fix: labelBaseline cannot be null #7146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/fill-invalid-output
branch
from
337157a to
ddf721a
Compare
kanitw
force-pushed
the
kw/fill-invalid-output
branch
from
d80daab to
a00fed3
Compare
This is what's failing the Vega validation in the master branch
kanitw
force-pushed
the
kw/fill-invalid-output
branch
from
a00fed3 to
e85b654
Compare
|
The example doesn't look right anymore.
|
|
So null is actually significant, otherwise the "default" align isn't preserved. I'm adding a new fix in #7147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what's failing the Vega validation in the master branch and in #7144