Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: combine single and multi selections as point selections #6927

Merged
merged 7 commits into from
Nov 16, 2020
Merged

refactor: combine single and multi selections as point selections #6927

merged 7 commits into from
Nov 16, 2020

Conversation

arvind
Copy link
Member

@arvind arvind commented Oct 5, 2020 •
edited
Loading

Review/merge after #6919.

@arvind arvind force-pushed the as/selection-types-refactor branch 8 times, most recently from 2783c10 to c4aff1c Compare October 7, 2020 18:35
@arvind arvind marked this pull request as ready for review October 7, 2020 19:01
@arvind arvind requested a review from a team October 7, 2020 19:01
@arvind arvind force-pushed the as/selection-types-refactor branch from 5b762d9 to dbab349 Compare October 9, 2020 13:12
kanitw
kanitw approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I assume that the new point selection stores data as a collection like multi?

(I can't remember if the old single selection stores data as a scalar or a collection with at most one item.)

@arvind
Copy link
Member Author

arvind commented Nov 16, 2020

Question: I assume that the new point selection stores data as a collection like multi?

Yes.

(I can't remember if the old single selection stores data as a scalar or a collection with at most one item.)

The latter.

Base automatically changed from as/top-level-selections to as/selection-params November 16, 2020 18:42
@arvind arvind force-pushed the as/selection-types-refactor branch from f05102a to a7102a3 Compare November 16, 2020 18:53
@arvind arvind merged commit 24b8801 into as/selection-params Nov 16, 2020
@arvind arvind deleted the as/selection-types-refactor branch November 16, 2020 19:45
arvind added a commit that referenced this pull request Nov 16, 2020
@arvind
refactor: combine single and multi selections as point selectio…
82ce9f9 
…ns (#6927)

* refactor: simplify selection compilation infrastructure.

* refactor: combine `single`/`multi` selection types into `point`.

* update examples for refactored `point` selection type.

* update compile-time tests for refactored `point` selection type.

* update runtime tests for refactored `point` selection type.

* chore: update schema [CI]

* chore: update examples [CI]

Co-authored-by: GitHub Actions Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanitw kanitw kanitw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvind @kanitw