Consistently use font weight. #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
reviewed
Feb 14, 2018
src/vega.schema.ts
Outdated
| @@ -1276,7 +1278,7 @@ export interface VgTitleConfig { | |||
| /** | |||
| * Font weight for title text. | |||
| */ | |||
| fontWeight?: FontWeight | FontWeightNumber; | |||
| fontWeight?: FontWeight; | |||
There was a problem hiding this comment.
Take this chance to update the description to says that this could be either string e.g,. ("bold") or a number (100, 200, 300, ..., 900 where normal = 400 and bold = 700)?
domoritz
force-pushed
the
dom/font-weight-schema
branch
from
42d1b51 to
22b9101
Compare
|
Pushed update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.