Move expressions to types and correct links #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge #3275 first to avoid conflict. |
kanitw
reviewed
Jan 21, 2018
site/docs/transform/filter.md
Outdated
| @@ -27,7 +27,7 @@ Vega-Lite filter transforms must have the `filter` property. | |||
| {:#expression} | |||
| ## Filter Expression | |||
|
|
|||
| For a [Vega Expression](https://vega.github.io/vega/docs/expressions/) string, each datum object can be referred using bound variable `datum`. For example, setting `filter` to `"datum.b2 > 60"` would make the output data includes only items that have values in the field `b2` over 60. | |||
| For an [Expression](types.html#expression) string, each datum object can be referred using bound variable `datum`. For example, setting `filter` to `"datum.b2 > 60"` would make the output data includes only items that have values in the field `b2` over 60. | |||
There was a problem hiding this comment.
In calculate, you still use "Vega Expression". We should be consistent :)
kanitw
reviewed
Jan 21, 2018
site/docs/transform/calculate.md
Outdated
| @@ -5,7 +5,7 @@ title: Calculate Transform | |||
| permalink: /docs/calculate.html | |||
| --- | |||
|
|
|||
| The formula transform extends data objects with new fields (columns) according to a calculation formula. | |||
| The formula transform extends data objects with new fields (columns) according to a an [expression](types.html#expression). | |||
kanitw
requested changes
Jan 21, 2018
site/docs/types.md
Outdated
| - [Object](#object) | ||
| - [String](#string) | ||
| - [URL](#url) | ||
| - [DateTime](#datetime) |
There was a problem hiding this comment.
Should we order things by alphabetical order?
| {: .column-list } | ||
|
|
||
| ## Literal Values | ||
|
|
||
| <a name="*"></a><a name="Any" href="#Any">#</a> | ||
| <a name="*"></a><a name="any" href="#any">#</a> |
There was a problem hiding this comment.
Please search and make sure we don't refer to these anchor names with Titlecase from other pages.
There was a problem hiding this comment.
I searched for types.html.
domoritz
force-pushed
the
dom/expr-doc
branch
from
37d8355 to
41b46cf
Compare
|
Revised |
|
Just merged #3275 -- there are a few minor conflicts. |
|
Rebased |
domoritz
force-pushed
the
dom/expr-doc
branch
from
41b46cf to
acfead8
Compare
kanitw
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.