Domain fix #3287
Merged
Domain fix #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can still get the row and column domains.
kanitw
reviewed
Jan 21, 2018
| ancestorParse: parent ? {...parent.component.data.ancestorParse} : {} | ||
| ancestorParse: parent ? {...parent.component.data.ancestorParse} : {}, | ||
| // data is faceted if the spec is a facet spec or the parent has faceted data and no data is defined | ||
| isFaceted: isFacetSpec(spec) || (parent && parent.component.data.isFaceted && !spec.data) |
There was a problem hiding this comment.
If I understand correctly, this will also be correct for facet of layer right? (Just asking to make sure)
There was a problem hiding this comment.
Yeah, it works with my example.
|
Test failing |
domoritz
force-pushed
the
dom/facet-domain-fix
branch
3 times, most recently
from
01a4769 to
d2daca8
Compare
|
Revised and added some more tests. |
domoritz
force-pushed
the
dom/facet-domain-fix
branch
from
d2daca8 to
d5a3b09
Compare
kanitw
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3284