Fix bug that prevent users from using guide-label style to customize header labels
#3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
reviewed
Nov 22, 2017
src/compile/layout/header.ts
Outdated
| ... (channel === 'row' ? { | ||
| align: {value: 'right'}, | ||
| baseline: {value: 'middle'} | ||
| } : {}) | ||
| // TODO: apply label* (e.g, labelAlign, labelBaseline) here |
|
Some tests are failing
|
|
Hmm, this is weird. I wonder if |
kanitw
force-pushed
the
kw/3204-facet-label
branch
from
857d4bc to
2ff787e
Compare
…e header labels Fix #3204
|
Should be good now. The lower diff hit is actually beyond the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3204