Sort facet values in ascending order as default #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
requested changes
Jun 27, 2017
src/compile/facet.ts
Outdated
| cross: true | ||
| }}: {}) | ||
| } | ||
| }, | ||
| ...(isCrossedFacet ? {sort: { | ||
| ...(hasRow && hasColumn ? {sort: { |
There was a problem hiding this comment.
You always produce sort and order so writing it this way is better:
{
sort: {
field: [].concat(
hasRow: ? [this.field(ROW, {expr: 'datum'})] : [],
hasColumn: ? [this.field(COLUMN, {expr: 'datum'})] : []
)
order: [].concat(
hasRow: ? [ (this.facet.row.header && this.facet.row.header.sort) || 'ascending'] : [],
hasColumn: ? [ ... ] : []
)
}
src/compile/layout/header.ts
Outdated
| from: {data: model.getName(channel)}, | ||
| sort: { | ||
| field: field(layoutHeader.facetFieldDef, {expr: 'datum'}), | ||
| order: 'ascending' |
There was a problem hiding this comment.
(facetFieldDef.header && facetFieldDef.header.sort) || 'ascending'
kanitw
approved these changes
Jun 27, 2017
|
I just fix a minor thing in the declaration. Let's merge when test finishes running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2553
(As a future work, I think we should allow user to sort facet as they want.)