add missing axis/legend config #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
reviewed
May 11, 2017
src/vega.schema.ts
Outdated
| @@ -427,9 +446,14 @@ export interface VgAxisConfig extends VgAxisBase { | |||
| labelLimit?: number; | |||
|
|
|||
| /** | |||
| * Maximum allowed pixel width of axis titles. | |||
| * Padding in pixels betweem axis ticks and tick labels. | |||
kanitw
reviewed
May 11, 2017
| @@ -84,8 +84,8 @@ To provide themes for all axes, the axis config `config: {axis: {...}}` can cont | |||
|
|
|||
| ### Ticks | |||
|
|
|||
| {% include table.html props="tickColor,labelColor,labelFont,labelFontSize,labelLimit,tickWidth" source="AxisConfig" %} | |||
| {% include table.html props="tickColor,tickRound,labelColor,labelFont,labelFontSize,labelLimit,tickWidth" source="AxisConfig" %} | |||
There was a problem hiding this comment.
Why are label* in this group for ticks?
There was a problem hiding this comment.
I put them here because they are for ticks label.
There was a problem hiding this comment.
@domoritz - wonder if you think we should split this? I think spliting might make more sense for users.
There was a problem hiding this comment.
Into label and tick things? I don't think it really matters as they are already sorted.
kanitw
reviewed
May 11, 2017
src/vega.schema.ts
Outdated
| * An interpolation fraction indicating where, for `band` scales, axis ticks should be positioned. A value of `0` places ticks at the left edge of their bands. A value of `0.5` places ticks in the middle of their bands. | ||
| */ | ||
| bandPosition?: number; | ||
| // ---------- Axis ---------- |
There was a problem hiding this comment.
Why is this // ---------- Axis ---------- below bandPosition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2342
Add
labelPadding,tickExtra,titleAlign,titleAngleto Axis PropertiesAdd
bandPosition,titleX,titleYto Axis ConfigAdd
fillColor,titleAlign, to Legend PropertiesAdd
cornerRadius,strokeColor,strokeDash,strokeWidth,titleBaseline,gradientLabelBaseline,gradientLabelLimit,gradientLabelOffsetto Legend Config