Add example for diverging color #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify doc for scale to include this example
kanitw
requested changes
Oct 18, 2016
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "description": "A bubbleplot showing horsepower on x, miles per gallons on y, and binned acceleration on size.", | |||
| "field": "Weight_in_lbs", | ||
| "type": "linear", | ||
| "scale": { | ||
| "domain": [1100,2700,5200], |
There was a problem hiding this comment.
How about ...
"domain": [1000,2750,4500],
(more rounded number)
| @@ -186,6 +186,10 @@ For ordinal, quantitative, and time fields, `range` can be a two-element array d | |||
|
|
|||
| <div class="vl-example" data-name="scatter_color_ordinal_custom"></div> | |||
|
|
|||
| We can also create diverging color graph by specify `range` with multipe elements. | |||
There was a problem hiding this comment.
-
typo
multipe=>multiple -
Maybe add
### Piecewise Scale Example: Diverging Color Scale
- in the example you also have to specify
domainto matchrange, but that is not described here.
Maybe look at how Mike describe about piece wise case there so people understand the constraint better:
https://github.com/d3/d3-scale#continuous_domain
|
The previous requests have been done. |
kanitw
approved these changes
Oct 19, 2016
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "description": "A bubbleplot showing horsepower on x, miles per gallons on y, and binned weight of diverging color.", | |||
There was a problem hiding this comment.
binned weight? I don't see bin in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide example for #449
Modified doc for scale to include this example