Skip to content

Commit

Permalink
fix: remove VL_ONLY_RECT_CONFIG for ticks
Browse files Browse the repository at this point in the history
  • Loading branch information
kanitw committed Aug 28, 2024
1 parent 3c46ff2 commit 9271390
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/mark.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,14 +327,21 @@ const VL_ONLY_MARK_CONFIG_INDEX: Flag<keyof VLOnlyMarkConfig<any>> = {

export const VL_ONLY_MARK_CONFIG_PROPERTIES = keys(VL_ONLY_MARK_CONFIG_INDEX);

const VL_ONLY_RECT_CONFIG: (keyof RectConfig<any>)[] = [
'binSpacing',
'continuousBandSize',
'discreteBandSize',
'minBandSize'
];

export const VL_ONLY_MARK_SPECIFIC_CONFIG_PROPERTY_INDEX: {
[k in Mark]?: (keyof Required<MarkConfigMixins<any>>[k])[];
} = {
area: ['line', 'point'],
bar: ['binSpacing', 'continuousBandSize', 'discreteBandSize', 'minBandSize'],
rect: ['binSpacing', 'continuousBandSize', 'discreteBandSize', 'minBandSize'],
bar: VL_ONLY_RECT_CONFIG,
rect: VL_ONLY_RECT_CONFIG,
line: ['point'],
tick: ['bandSize', 'thickness']
tick: ['bandSize', 'thickness', ...VL_ONLY_RECT_CONFIG]
};

export const defaultMarkConfig: MarkConfig<SignalRef> = {
Expand Down

0 comments on commit 9271390

Please sign in to comment.