DOCS: Clarify steps in the contributing guidelines #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
reviewed
Mar 25, 2022
CONTRIBUTING.md
Outdated
| Note that Altair code uses the [black](https://black.readthedocs.io/) | ||
| code formatter, which you can apply to your modifications by installing | ||
| and running black on the local directory: | ||
| and [flake8](https://flake8.pycqa.org/en/latest/) code formatters |
There was a problem hiding this comment.
nitpick: flake8 is a linter, not a code formatter
There was a problem hiding this comment.
Thank you, updated!
jakevdp
approved these changes
Mar 25, 2022
|
Actions are failing because of #2575, not related to this PR |
|
#2575 is merged, can you rebase this one? |
joelostblom
force-pushed
the
contributing-guidelines
branch
from
01b89a4 to
7ab6590
Compare
|
Rebased and ready to merge! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed a few things in the contributing guideline as I was making my recent PRs.