Validate multiple emails #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colemanw @lcdservices can you please review this patch !! |
|
@monishdeb Needs rebase |
| <button type="button" class="btn btn-sm btn-primary" title="{{ crmMailing.$invalid || !testContact.email ? ts('Complete all required-mark fields first') : ts('Send test message to %1', {1: testContact.email}) }}" ng-disabled="crmMailing.$invalid || !testContact.email" ng-click="doSend({email: testContact.email})"> | ||
| {{:: ts('Send test') }} | ||
| <button class="btn btn-sm btn-primary" title="{{crmMailing.$invalid || !testContact.email ? ts('Complete all required-mark fields first') : !validateMultipleEmail(testContact.email) ? ts('Not a valid email address') : ts('Send test message to %1', {1: testContact.email})}}" ng-disabled="crmMailing.$invalid || !testContact.email || !validateMultipleEmail(testContact.email)" ng-click="doSend({email: testContact.email})"> | ||
| {{ts('Send test')}} |
There was a problem hiding this comment.
I think the change on this line should be reverted right @colemanw ?
monishdeb
force-pushed
the
validate_email
branch
from
e04c454 to
d6ff202
Compare
|
@mattwire I have done the rebase .. please have a look now. |
|
Thanks @monishdeb I'm merging on the basis that we (someone) will do quite a bit of testing before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate multiple emails while testing on compose screen: