Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mosaico graphics service to resize thumbnail. #345

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

agileware-fj
Copy link
Contributor

Fix for Error: Class 'Imagick' not found when uploading images with only GD extension, per #312

@totten
Copy link
Collaborator

totten commented Nov 26, 2019

Agree this code looks pretty sensible. Tested locally with a couple different drivers active, and it seemed to work in each case. There are multiple reports of people using it successfully in #312.

Thank you @agileware-fj @francescbassas !

@totten totten merged commit 0351712 into veda-consulting-company:2.x Nov 26, 2019
@agileware-pengyi agileware-pengyi deleted the CIVIMOSAIC-27 branch November 26, 2019 23:23
@JKingsnorth
Copy link
Contributor

I think this patch warrants a new minor release, as without it you still need ImageMagick installed alongside GD to make the extension work @totten / @mattwire

Thanks for the fix!

@mattwire
Copy link
Collaborator

mattwire commented May 4, 2020

@JKingsnorth I'd like to get #371 merged if possible before doing another release - be great if you were able to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants