Accept Mosaico-style unsubscribe URLs during validation (#143) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totten
changed the title
|
@totten i would note that the core PR and flexmailer PRs are now both merged, should this get merged then? |
Before ------ As observed in veda-consulting-company#143, the default `versafix-1` templates use tokens like `[unsubscribe_link]` which do not match `{action.unsubscribeUrl}`. Thus, when you try to submit the mailing, it fails because the token is missing. After ----- The `[unsubscribe_link]` is treated as an alias for `{action.unsubscribeUrl}`. Thus, when you try to submit the mailing, it accepts that token. Comment ------- There's another required token, `{domain.address}`. For the moment, the patch waives that requirement because Mosaico UX handles that differently. See comments inlined.
Before
------
CiviMail generally requires `{domain.address}`. This is not provided
by default in most Mosaico templates. However, the Mosaico templates
do provide a block where you're expected to fill in the address.
After
-----
The `{domain.address}` is not required for Mosaico mailings.
totten
force-pushed
the
2.x-token-validation
branch
from
6638959 to
a949465
Compare
|
Yeah, I held off a little on merging -- if you deployed the first couple commits on an outdated version of Flexmailer, then it'd be cause a hard crash, so I wanted to mitigate that. It should now degrade more gracefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
As observed in #143, the default
versafix-1templates use tokens like[unsubscribe_link]which do not match{action.unsubscribeUrl}. Thus,when you try to submit the mailing, it fails because the token is missing.
After
The
[unsubscribe_link]is treated as an alias for{action.unsubscribeUrl}. Thus, when you try to submit the mailing,it accepts that token.
Comment
There's another required token,
{domain.address}. For the moment,the patch waives that requirement because Mosaico UX handles that
differently. See comments inlined.
This patch depends on a recent update to Flexmailer: civicrm/org.civicrm.flexmailer#9 . That patch is currently merged.
To fully work, this patch also depends on an open core PR, civicrm/civicrm-core#11316 . However, it is safe to use this patch without 11316 -- the new code is simply inert.