-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Tst autocompletion support for ct (Issue #170) #249
Conversation
E2e Test results - Vcast 2023sp0 - Group basic_user_interactions10 files ±0 10 suites ±0 18m 54s ⏱️ +19s Results for commit dc6093c. ± Comparison against base commit cacd52b. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
E2e Test results - Vcast 2021sp0 - Group basic_user_interactions10 files ±0 10 suites ±0 18m 40s ⏱️ -17s Results for commit dc6093c. ± Comparison against base commit cacd52b. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
E2e Test results - Vcast 2024sp5 - Group func_atg2 files ±0 2 suites ±0 1m 36s ⏱️ -53s Results for commit dc6093c. ± Comparison against base commit cacd52b. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
E2e Test results - Vcast 2024sp5 - Group func_basis2 files ±0 2 suites ±0 1m 40s ⏱️ - 1m 0s Results for commit dc6093c. ± Comparison against base commit cacd52b. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright. It would make sense to add a couple more e2e tests for the completion itself (suggested unit/function) and to cover that wider range indicated by codecov (the single line special failure cases aren't as important). The comment about a possible refactor could be turned into an "internal issue"
Quality Gate passedIssues Measures |
Summary
Updates script editing to support coded tests and resolves #170.
Changed
2024sp5
is uploaded to Codecov, replacing the previous version2021
.Added
Syntax Support for
TEST.CODED_TEST_FILE
:TEST.CODED_TEST_FILE
as a valid syntax in.tst
files.TEST.CODED_TEST_FILE
after typingTEST.
.:
.Behavior When
TEST.SUBPROGRAM
iscoded_tests_driver
:TEST.CODED_TEST_FILE
without error diagnostics.TEST.VALUE
andTEST.EXPECTED
lines, ensuring they give error diagnostics.Behavior When
TEST.SUBPROGRAM
is Notcoded_tests_driver
:TEST.CODED_TEST_FILE
, ensuring it gives an error diagnostic.coded_tests_driver
from the subprogram list forTEST.VALUE
andTEST.EXPECTED
lines.Error Handling Enhancements:
Tests
Autocompletion list for
TEST.SUBPROGRAM
without using the fakeTEST.VALUE
lineTEST.SUBPROGRAM
, we need the<unit>
fromTEST.UNIT
.getNearest()
intstCompletion.ts
.<unit>
is sent as an additional parameter to the Python logic.processSubprogramLines()
(tstUtilities.py), we use this<unit>
to retrieve, withgetFunctions()
, theautocompletion
list of all the functions in this unit from theDataAPI
.<<INIT>>, <<COMPOUND>>, <<coded_tests_driver>>
.