-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib): Add new object_from_array
function
#1164
Conversation
560c945
to
7bdd2c9
Compare
Note that I plan a follow-up PR to add support for an optional Also, I don't really like the name |
src/stdlib/object_from_array.rs
Outdated
} | ||
|
||
#[derive(Clone, Debug)] | ||
enum ConstOrExpr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a straight-up clone of the construct in zip
. Where would it make sense to move it into common code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can introduce a src/stdlib/utils.rs
(for the lack of a better name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Adds a new
object_from_array
function as discussed in #1157Change Type
Is this a breaking change?
How did you test this PR?
Unit tests are included
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool write
and commit the changes. More details here.