Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(observability, sinks): Fix missing increment in batch counter and add component tests to HttpSink sinks #9525

Merged
merged 9 commits into from
Oct 13, 2021
Merged

fix(observability, sinks): Fix missing increment in batch counter and add component tests to HttpSink sinks #9525

merged 9 commits into from
Oct 13, 2021

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Oct 8, 2021

This should complete the event processing telemetry for all HttpSink sinks.

Signed-off-by: Bruce Guenter [email protected]

@bruceg bruceg added sink: http Anything `http` sink related domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks domain: unit tests Anything related to Vector's unit testing feature labels Oct 8, 2021
@bruceg bruceg self-assigned this Oct 8, 2021
@netlify
Copy link

netlify bot commented Oct 8, 2021 •
edited
Loading

✔️ Deploy Preview for vector-project canceled.

🔨 Explore the source changes: dd80b64

🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/61671d3ea3a60c0008da163b

@bruceg bruceg requested a review from jszwedko October 8, 2021 17:31
@bruceg bruceg mentioned this pull request Oct 8, 2021
Closed
32 tasks
@bruceg
Fixups and more tests
e59633f 
Signed-off-by: Bruce Guenter <[email protected]>
@bruceg bruceg requested a review from lukesteensen October 8, 2021 19:39
@bruceg bruceg enabled auto-merge (squash) October 8, 2021 20:56
@bruceg bruceg added the type: bug A code related bug. label Oct 13, 2021
@bruceg bruceg changed the title chore(observability, sinks): Add component tests to HttpSink sinks fix(observability, sinks): Fix missing increment in batch counter and add component tests to HttpSink sinks Oct 13, 2021
@bruceg bruceg disabled auto-merge October 13, 2021 18:18
jszwedko
jszwedko approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I'm very happy to see the metrics being tested.

@bruceg bruceg enabled auto-merge (squash) October 13, 2021 18:42
@bruceg bruceg merged commit cc2e849 into master Oct 13, 2021
@bruceg bruceg deleted the http-sink-tests branch October 13, 2021 19:11
@bruceg bruceg mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@tobz tobz tobz approved these changes

@lukesteensen lukesteensen Awaiting requested review from lukesteensen

Assignees

@bruceg bruceg

Labels
domain: observability Anything related to monitoring/observing Vector domain: sinks Anything related to the Vector's sinks domain: unit tests Anything related to Vector's unit testing feature sink: http Anything `http` sink related type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruceg @tobz @jszwedko