fix(aws_cloudwatch_logs sink): Fix healthcheck to allow for log group creation at runtime #7601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszwedko
reviewed
May 26, 2021
spencergilbert
changed the title
jszwedko
reviewed
May 26, 2021
spencergilbert
added
the
sink: aws_cloudwatch_logs
… creation at runtime Signed-off-by: Spencer Gilbert <[email protected]>
Signed-off-by: Spencer Gilbert <[email protected]>
…hcheck Signed-off-by: Spencer Gilbert <[email protected]>
…n demand Signed-off-by: Spencer Gilbert <[email protected]>
Signed-off-by: Spencer Gilbert <[email protected]>
jszwedko
approved these changes
May 28, 2021
Signed-off-by: Spencer Gilbert <[email protected]>
Doh, sorta figured it'd be built out like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Spencer Gilbert [email protected]
Closes #7592