chore: Add an explicit +Unpin to our buffers #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an explicit +Unpin to our buffer type definition, introducing `EventStream` type alias to tidy up some repitition. This is done to support pull request #7576 where this changed is needed but is a little outside the scope of that PR. The major change here is in `src/utilization` where I had to re-implement the select loop to use an explicit stream definition. The `stream!` macro used previously couldn't make the `+ Unpin` guarantee. It wasn't clear to me that it could be fixed upstream. Signed-off-by: Brian L. Troutwine <[email protected]>
ktff
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an explicit +Unpin to our buffer type definition, introducing
EventStreamtype alias to tidy up some repitition. This is done to supportpull request #7576 where this changed is needed but is a little outside the
scope of that PR. The major change here is in
src/utilizationwhere I had tore-implement the select loop to use an explicit stream definition. The
stream!macro used previously couldn't make the
+ Unpinguarantee. It wasn't clear tome that it could be fixed upstream.
Signed-off-by: Brian L. Troutwine [email protected]