Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(heroku_logs source, http source): Add end-to-end acknowledgements #7431

Merged
merged 7 commits into from
May 13, 2021
Merged

enhancement(heroku_logs source, http source): Add end-to-end acknowledgements #7431

merged 7 commits into from
May 13, 2021

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented May 12, 2021 •
edited
Loading

Closes #7202

This is a repeat issue of #7325 that was reverted in #7426 because of a broken test. This fixes the broken test case in the heroku_logs source, caused because this move actually added support for acknowledgements to that source as well. We will definitely want to make sure all tests pass before merging this one.

Note that this also enhances the datadog_logs source, but that tag is not in the semantic list so I cannot use it in the PR title.

Signed-off-by: Bruce Guenter [email protected]

@bruceg bruceg added domain: sources Anything related to the Vector's sources provider: datadog Anything `datadog` service provider related source: http_server Anything `http_server` source related domain: data model Anything related to Vector's internal data model source: heroku_logs Anything `heroku_logs` source related labels May 12, 2021
@bruceg bruceg requested review from blt, jszwedko and lukesteensen May 12, 2021 18:23
@bruceg bruceg self-assigned this May 12, 2021
@bruceg bruceg requested review from a team May 12, 2021 18:23
@bruceg bruceg changed the title enhancement(datadog source, heroko_source, http source): Add end-to-end acknowledgements enhancement(heroko_source, http source): Add end-to-end acknowledgements May 12, 2021
@jszwedko jszwedko changed the title enhancement(heroko_source, http source): Add end-to-end acknowledgements enhancement(heroku_logs source, http source): Add end-to-end acknowledgements May 12, 2021
@bruceg bruceg mentioned this pull request May 12, 2021
Closed
lukesteensen
lukesteensen approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@lukesteensen lukesteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the same as was merged previously, but with the addition of 6d79cc5? If so, looks good to me!

@bruceg
Copy link
Member Author

bruceg commented May 12, 2021

So this is the same as was merged previously, but with the addition of 6d79cc5? If so, looks good to me!

Effectively correct. The support required in the heroku_logs sink was merged into d83ceb2, and then later enhanced with tests for failure handling.

@bruceg bruceg merged commit e6cb3e6 into master May 13, 2021
@bruceg bruceg deleted the http-source-acknowledgements branch May 13, 2021 23:00
@bruceg bruceg mentioned this pull request Nov 2, 2021
Closed
18 tasks
This was referenced Nov 19, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesteensen lukesteensen lukesteensen approved these changes

@blt blt Awaiting requested review from blt

@jszwedko jszwedko Awaiting requested review from jszwedko

Assignees

@bruceg bruceg

Labels
domain: data model Anything related to Vector's internal data model domain: sources Anything related to the Vector's sources provider: datadog Anything `datadog` service provider related source: heroku_logs Anything `heroku_logs` source related source: http_server Anything `http_server` source related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for end-to-end acknowledgements to the http source
2 participants
@bruceg @lukesteensen