Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add transforms-metric_to_log transform dependency to sink-humio #4617

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

jszwedko
Copy link
Member

Given that the humio metrics sink depends on the log_to_metric
transform.

Also fix Makefile to run humio integration tests. I couldn't find a good
way to use a wildcard for the module (like
"::humio::*::integration_tests") so I just did the logs submodule for
now. It seems like there are plans to add regex support for test
filters: rust-lang/rust#53278

Fixes https://github.com/timberio/vector/actions/runs/311846034

Signed-off-by: Jesse Szwedko [email protected]

…humio

Given that the humio metrics sink depends on the log_to_metric
transform.

Also fix Makefile to run humio integration tests. I couldn't find a good
way to use a wildcard for the module (like
"::humio::*::integration_tests") so I just did the logs submodule for
now. It seems like there are plans to add regex support for test
filters: rust-lang/rust#53278

Signed-off-by: Jesse Szwedko <[email protected]>
Copy link
Contributor

@jamtur01 jamtur01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamtur01
Copy link
Contributor

Looks like the Cross and Mac jobs are hung. Going to re-run.

Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Sorry, I should have spotted that. It looks like the check-component-features CI job picked it up too.

@jamtur01 jamtur01 merged commit 8ea0848 into master Oct 17, 2020
@jamtur01 jamtur01 deleted the fix-humio-metrics-dependency branch October 17, 2020 19:43
juchiast pushed a commit that referenced this pull request Oct 19, 2020
…humio (#4617)

Given that the humio metrics sink depends on the log_to_metric
transform.

Also fix Makefile to run humio integration tests. I couldn't find a good
way to use a wildcard for the module (like
"::humio::*::integration_tests") so I just did the logs submodule for
now. It seems like there are plans to add regex support for test
filters: rust-lang/rust#53278

Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Duy Do <[email protected]>
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
…humio (vectordotdev#4617)

Given that the humio metrics sink depends on the log_to_metric
transform.

Also fix Makefile to run humio integration tests. I couldn't find a good
way to use a wildcard for the module (like
"::humio::*::integration_tests") so I just did the logs submodule for
now. It seems like there are plans to add regex support for test
filters: rust-lang/rust#53278

Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Brian Menges <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants