Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(host_metrics source): ignore flakey tcp metrics tests #22544

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

pront
Copy link
Member

@pront pront commented Feb 28, 2025

Summary

These tests are flakey. It seems like the TCP metrics are working so instead of reverting the whole PR, we can ignore the tests for now and debug/fix at a second phase.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 28, 2025
@pront pront requested a review from jszwedko February 28, 2025 17:41
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Feb 28, 2025
@pront pront marked this pull request as ready for review February 28, 2025 17:41
@pront pront requested a review from a team as a code owner February 28, 2025 17:41
@pront pront enabled auto-merge February 28, 2025 17:42
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/ignore-flakey-tests-host-metrics-tcp
Commit report: 95d0edd
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have some examples of flakes here?

@pront
Copy link
Member Author

pront commented Feb 28, 2025

Do you have some examples of flakes here?

Happened once here: https://github.com/vectordotdev/vector/actions/runs/13591407792/job/37998236270

@pront pront disabled auto-merge March 3, 2025 19:48
@pront
Copy link
Member Author

pront commented Mar 3, 2025

@pront pront merged commit 3cf1ecc into master Mar 3, 2025
64 of 66 checks passed
@pront pront deleted the pront/ignore-flakey-tests-host-metrics-tcp branch March 3, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants