Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(external docs): fix missing configuration section for websocket_server docs #22480

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Feb 20, 2025

Summary

In the initial PR, I forgot to add the automatically generated configuration section to the websocket_server docs page.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Related: #22213

@esensar esensar requested review from a team as code owners February 20, 2025 13:16
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Feb 20, 2025
@pront pront enabled auto-merge February 20, 2025 14:53
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 20, 2025
@pront pront added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 20, 2025
@pront
Copy link
Member

pront commented Feb 20, 2025

We have a new merge conflict on this one

@esensar
Copy link
Contributor Author

esensar commented Feb 20, 2025

We have a new merge conflict on this one

Yeah, I just saw that. It was a simple one.

@pront pront enabled auto-merge February 20, 2025 16:53
@pront pront added this pull request to the merge queue Feb 20, 2025
Merged via the queue into vectordotdev:master with commit ae84bcd Feb 20, 2025
42 checks passed
@esensar esensar deleted the docs/fix-websocket-server-missing-configuration branch February 20, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants