Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sources): multicast udp socket support #22099
base: master
Are you sure you want to change the base?
feat(sources): multicast udp socket support #22099
Changes from all commits
a8563a3
ba9015f
1ab728f
b1e6c92
e63e2bf
0e32685
adad168
72131fb
12bf074
3018327
588bb09
c140d42
58223d5
6b96901
9d25576
5b7723c
e9a5933
058f841
1ba5dd8
dc09eb5
4fb4e28
a2930d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubts about this naming.
SocketMulticastJoinError
,UdpSocketMulticastJoinError
,UdpSocketMulticastGroupJoinError
....?This error will be created only from UDP mode, as the multicast concept only exists UDP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the
group_addr
andinterface
because they're the arguments required forjoin_multicast_v4
vector/src/sources/socket/udp.rs
Line 191 in a2930d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inspired from the
SocketBindError
implementationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error_stage receiving? I found that stage weird in this case. I think
INITIALIZING
or so would fit more in this case... but I see thaterror_stage::RECEIVING
is used also for socket binding error and etc.. Just noticed this and wanted to raise it, not for addressing in this PR thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to add those two variables (
group_addr
andinterface
) to counter tags? Or should only be included in theerror!
log?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored this a little in dc09eb5. Didn't know that
assert_source_error
existed. Is it ok to check that only the tagerror_type
is updated? (COMPONENT_ERROR_TAGS
only contains that tag)we are using a bit more tags in that error

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested https://github.com/vectordotdev/vector/pull/22099/files#r1927304213
This is logged as

does it look ok?