Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Pin ubuntu versions in GHA #22044

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

jszwedko
Copy link
Member

Summary

ubuntu-latest recently changed to 24.04 for some workflows which caused unexpected breakages. I think it is better to pin to a specific version and upgrade as-needed rather than track latest and have it break unexpectedly.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Will test with CI.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

`ubuntu-latest` recently changed to 24.04 for some workflows which caused unexpected breakages.
I think it is better to pin to a specific version and upgrade as-needed rather than track latest and
have it break unexpectedly.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 16, 2024
@jszwedko jszwedko requested review from a team as code owners December 16, 2024 23:48
Copy link
Member Author

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-all

@jszwedko
Copy link
Member Author

@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/pin-ubuntu-versions
Commit report: 2ba3c1a
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.55s Total Time

Copy link
Contributor

@bfung bfung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinning dependency/version numbers 👍

@jszwedko jszwedko added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit 475e93f Dec 17, 2024
92 of 97 checks passed
@jszwedko jszwedko deleted the jszwedko/pin-ubuntu-versions branch December 17, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants