Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use newest SMP version #22004

Merged
merged 2 commits into from
Dec 10, 2024
Merged

chore(ci): Use newest SMP version #22004

merged 2 commits into from
Dec 10, 2024

Conversation

scottopell
Copy link
Contributor

Summary

Fixes a small bug in the existing

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@scottopell scottopell added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 10, 2024
@scottopell scottopell requested review from a team as code owners December 10, 2024 13:23
@bits-bot
Copy link

bits-bot commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@datadog-vectordotdev
Copy link

Datadog Report

Branch report: smp/upgrade
Commit report: d753db9
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time

@@ -407,7 +407,7 @@ jobs:
--target-config-dir ${{ github.workspace }}/regression/ \
--warmup-seconds ${{ env.SMP_WARMUP_SECONDS }} \
--submission-metadata ${{ runner.temp }}/submission-metadata \
--replicas {{ env.SMP_REPLICAS }}
--replicas ${{ env.SMP_REPLICAS }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, thank you.

@pront pront changed the title chore(smp upgrade) Use newest SMP version chore(sci) Use newest SMP version Dec 10, 2024
@pront pront changed the title chore(sci) Use newest SMP version chore(ci): Use newest SMP version Dec 10, 2024
@pront pront added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit 2f53b1c Dec 10, 2024
70 of 74 checks passed
@pront pront deleted the smp/upgrade branch December 10, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants