Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vrl): mark set_semantic_meaning impure #21896

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(vrl): mark set_semantic_meaning impure #21896

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a522eba
fix(vrl): mark set_semantic_meaning impure
sfackler Nov 26, 2024
35caa07
add a changelog
sfackler Nov 26, 2024
0014ce8
fix changelog filename
sfackler Nov 26, 2024
992428d
remove changelog
sfackler Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.d/21896_set_semantic_meaning_impure.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
The `set_semantic_meaning` VRL function is now marked impure to avoid incorrectly triggering the
sfackler marked this conversation as resolved.
Show resolved Hide resolved
unused result warning.

authors: sfackler
2 changes: 1 addition & 1 deletion lib/vector-vrl/functions/src/set_semantic_meaning.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,6 @@ impl FunctionExpression for SetSemanticMeaningFn {
}

fn type_def(&self, _: &TypeState) -> TypeDef {
TypeDef::null().infallible()
TypeDef::null().infallible().impure()
}
}
Loading