Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http sink): revert 21583 #21885

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(http sink): revert 21583 #21885

merged 1 commit into from
Nov 26, 2024

Conversation

pront
Copy link
Member

@pront pront commented Nov 25, 2024 •
edited
Loading

Reverts #21583

Context: This PR looks great functionality wise. But there is a small UX issue (explained here) that we need to address before including it in a release.

Ref: #20635

@pront pront requested review from a team as code owners November 25, 2024 21:59
@pront pront enabled auto-merge November 25, 2024 21:59
@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: external docs Anything related to Vector's external, public documentation labels Nov 25, 2024
@pront pront changed the title Revert "enhancement(http provider): Add automatic bearer token acquisition in http-client [version 2]" fix(http sink): revert 21583 Nov 25, 2024
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 25, 2024
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Nov 25, 2024 •
edited
Loading

Datadog Report

Branch report: revert-21583-auth_strategy_trait_for_http_client
Commit report: b4f6680
Test service: vector

✅ 0 Failed, 9 Passed, 0 Skipped, 25.44s Total Time

bfung
bfung approved these changes Nov 25, 2024
View reviewed changes
Copy link

@bfung bfung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to revisit for a future release; users using this functionality can continue using a development version.

@pront pront added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit e0d3fb3 Nov 26, 2024
62 of 65 checks passed
@pront pront deleted the revert-21583-auth_strategy_trait_for_http_client branch November 26, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfung bfung bfung approved these changes

Assignees
No one assigned
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @bfung