Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(honeycomb sink): The batch body should be encoded as array #21878

Merged

Conversation

hgiasac
Copy link
Contributor

@hgiasac hgiasac commented Nov 25, 2024

Summary

This PR intends to fix #21877

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Create an API key and push logs to Honeycomb.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

#21877

@hgiasac hgiasac requested a review from a team as a code owner November 25, 2024 16:48
@bits-bot
Copy link

bits-bot commented Nov 25, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Nov 25, 2024
@hgiasac hgiasac changed the title fix (honeycomb sink): The batch body should be encoded as array fix(honeycomb sink): The batch body should be encoded as array Nov 25, 2024
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hgiasac! Please add a changelog entry.

@pront pront enabled auto-merge November 25, 2024 17:34
auto-merge was automatically disabled November 25, 2024 17:41

Head branch was pushed to by a user without write access

@hgiasac
Copy link
Contributor Author

hgiasac commented Nov 25, 2024

@pront I have fixed the spelling check on the changelog file name. Would you mind enabling auto-merge again? Thanks.

@pront pront enabled auto-merge November 25, 2024 17:53
auto-merge was automatically disabled November 25, 2024 18:07

Head branch was pushed to by a user without write access

@pront pront enabled auto-merge November 25, 2024 18:24
@pront pront added this pull request to the merge queue Nov 25, 2024
Merged via the queue into vectordotdev:master with commit a7204fa Nov 25, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad request body from the Honeycomb sink after refactoring to the new style
3 participants