-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(lua transform): Add version
configuration option
#2056
Conversation
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files |
.meta/transforms/lua.toml
Outdated
required = false | ||
description = "transform API version" | ||
default = "1" | ||
enum = { 1 = "transform API version 1", 2 = "transform API version 2" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove 2
until we actually support it. And, at the time, we should make sure it what is presented in the configuration example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, you do have a v2
here. Does that implement the API discussed in the spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, you do have a
v2
here. Does that implement the API discussed in the spec?
It is currently a duplicate of v1
. I'm planning to gradually implement features from the RFC in v2
, so although it is available, the exposed API for it will be very unstable until most of the features are there. So it makes sense to hide it until it is somewhat stabilized.
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Signed-off-by: Alexander Rodin <[email protected]>
This PR adds
version
configuration option to thelua
transform. The version can take values1
and2
, the default values is1
.This also splits implementation for both versions, so all further changes on version 2 would not affect version 1.
Ref #2000.