Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(observability)!: remove deprecated component_name metric tag #18942

Merged
merged 7 commits into from
Oct 26, 2023
1 change: 0 additions & 1 deletion lib/vector-core/src/metrics/label_filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ impl LabelFilter for VectorLabelFilter {
key == "component_id"
|| key == "component_type"
|| key == "component_kind"
|| key == "component_name"
|| key == "buffer_type"
}
}
2 changes: 1 addition & 1 deletion src/config/source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ impl SourceContext {
if config.enabled() {
warn!(
message = "Enabling `acknowledgements` on sources themselves is deprecated in favor of enabling them in the sink configuration, and will be removed in a future version.",
component_name = self.key.id(),
component_id = self.key.id(),
);
}

Expand Down
10 changes: 0 additions & 10 deletions src/topology/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,6 @@ impl<'a> Builder<'a> {
component_kind = "source",
component_id = %key.id(),
component_type = %source.inner.get_component_name(),
// maintained for compatibility
component_name = %key.id(),
);
let _entered_span = span.enter();

Expand Down Expand Up @@ -428,8 +426,6 @@ impl<'a> Builder<'a> {
component_kind = "transform",
component_id = %key.id(),
component_type = %transform.inner.get_component_name(),
// maintained for compatibility
component_name = %key.id(),
);

// Create a map of the outputs to the list of possible definitions from those outputs.
Expand Down Expand Up @@ -514,8 +510,6 @@ impl<'a> Builder<'a> {
component_kind = "sink",
component_id = %key.id(),
component_type = %sink.inner.get_component_name(),
// maintained for compatibility
component_name = %key.id(),
);
let _entered_span = span.enter();

Expand Down Expand Up @@ -634,8 +628,6 @@ impl<'a> Builder<'a> {
component_kind = "sink",
component_type = typetag,
component_id = %component_key.id(),
// maintained for compatibility
component_name = %component_key.id(),
);
Err(TaskError::wrapped(error))
}
Expand All @@ -645,8 +637,6 @@ impl<'a> Builder<'a> {
component_kind = "sink",
component_type = typetag,
component_id = %component_key.id(),
// maintained for compatibility
component_name = %component_key.id(),
);
Err(TaskError::wrapped(Box::new(e)))
}
Expand Down
6 changes: 0 additions & 6 deletions src/topology/running.rs
Original file line number Diff line number Diff line change
Expand Up @@ -845,8 +845,6 @@ impl RunningTopology {
component_kind = "sink",
component_id = %task.id(),
component_type = %task.typetag(),
// maintained for compatibility
component_name = %task.id(),
);

let task_span = span.or_current();
Expand Down Expand Up @@ -888,8 +886,6 @@ impl RunningTopology {
component_kind = "transform",
component_id = %task.id(),
component_type = %task.typetag(),
// maintained for compatibility
component_name = %task.id(),
);

let task_span = span.or_current();
Expand Down Expand Up @@ -931,8 +927,6 @@ impl RunningTopology {
component_kind = "source",
component_id = %task.id(),
component_type = %task.typetag(),
// maintained for compatibility
component_name = %task.id(),
);

let task_span = span.or_current();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ badges:
Vector's 0.34.0 release includes **breaking changes**:

1. [Removal of Deprecated Datadog Component Config Options](#datadog-deprecated-config-options)
1. [Removal of Deprecated `component_name` Metric Tag](#deprecated-component-name)

We cover them below to help you upgrade quickly:

Expand All @@ -26,3 +27,7 @@ and Metrics sinks. Instead the `site` option should be used.

The `region` and `application_key` config options have
been removed from the Enterprise configuration. Instead of `region`, `site` should be used. `application_key` is no longer required.

#### Removal of Deprecated `component_name` Metric Tag {#deprecated-component-name}

The deprecated `component_name` tag has been removed from all internal metrics. Instead the `component_id` tag should be used.
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,6 @@ components: sources: internal_metrics: {
_component_tags: _internal_metrics_tags & {
component_kind: _component_kind
component_id: _component_id
component_name: _component_name
component_type: _component_type
}

Expand All @@ -1117,11 +1116,6 @@ components: sources: internal_metrics: {
required: true
examples: ["my_source", "my_sink"]
}
_component_name: {
description: "Deprecated, use `component_id` instead. The value is the same as `component_id`."
required: true
examples: ["my_source", "my_sink"]
}
_component_type: {
description: "The Vector component type."
required: true
Expand Down
Loading