Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new sink): Add sinks sftp support #18076

Closed
wants to merge 3 commits into from
+540 −2
Closed

feat(new sink): Add sinks sftp support #18076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd86fbf
feat: Add sinks sftp support
Xuanwo Jul 25, 2023
23426d0
Merge branch 'master' into sinks-sftp
Xuanwo Jul 29, 2023
e3298a4
Fix build
Xuanwo Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 235 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ futures = { version = "0.3.28", default-features = false, features = ["compat",
tokio = { version = "1.29.1", default-features = false, features = ["full"] }
tokio-openssl = { version = "0.6.3", default-features = false }
tokio-stream = { version = "0.1.14", default-features = false, features = ["net", "sync", "time"] }
tokio-util = { version = "0.7", default-features = false, features = ["io", "time"] }
tokio-util = { version = "0.7.8", default-features = false, features = ["io", "time"] }
console-subscriber = { version = "0.1.10", default-features = false, optional = true }

# Tracing
Expand Down Expand Up @@ -645,6 +645,7 @@ sinks-logs = [
"sinks-vector",
"sinks-webhdfs",
"sinks-websocket",
"sinks-sftp",
]
sinks-metrics = [
"sinks-appsignal",
Expand Down Expand Up @@ -709,6 +710,7 @@ sinks-utils-udp = []
sinks-vector = ["sinks-utils-udp", "dep:tonic", "protobuf-build"]
sinks-websocket = ["dep:tokio-tungstenite"]
sinks-webhdfs = ["dep:opendal"]
sinks-sftp = ["dep:opendal", "opendal?/services-sftp"]

# Datadog integration
enterprise = [
Expand Down
2 changes: 2 additions & 0 deletions src/sinks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ pub mod redis;
pub mod s3_common;
#[cfg(feature = "sinks-sematext")]
pub mod sematext;
#[cfg(feature = "sinks-sftp")]
Copy link
Contributor

@dsmith3197 dsmith3197 Aug 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also gate this behind unix as the sftp opendal service states that it only works for unix.

Suggested change
#[cfg(feature = "sinks-sftp")]
#[cfg(all(unix, feature = "sinks-sftp"))]

pub mod sftp;
#[cfg(feature = "sinks-socket")]
pub mod socket;
#[cfg(feature = "sinks-splunk_hec")]
Expand Down
Loading