Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(dev): Add dedicated helper tool #15833

Merged
merged 34 commits into from
Jan 9, 2023
Merged

enhancement(dev): Add dedicated helper tool #15833

merged 34 commits into from
Jan 9, 2023

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Jan 5, 2023

This is a follow-up to #14990 as @ofek does not have sufficient time to actively pursue this track now that he is no longer embedded. Most of the code is his, I have just closed some of the outstanding issues with it.

I will be following up on this in a separate PR to flesh out the integration testing. Consider that part of this code base a work in progress.

ofek and others added 27 commits October 29, 2022 10:51
@ofek
Add dedicated dev tool
a1afed9
@ofek
refactor
9ebac12
@ofek @neuronull
Apply suggestions from code review
3b71558 
Co-authored-by: neuronull <[email protected]>
@ofek
address
9f44785
@ofek
add env management commands
fb2163f
@ofek
add test command
ec58410
@ofek
refactor with once_cell
4de3c12
@ofek
refactor sub-process handling
3d1ffa6
@ofek
improve error messages
9e3d6f4
@ofek
handle case of first time user
fd833a7
@ofek
reduce boilerplate with macros
a2e000c
@ofek
address
f43fb51
@ofek @StephenWakely
Apply suggestions from code review
b9d8583 
Co-authored-by: Stephen Wakely <[email protected]>
@ofek
address
9939e81
@ofek
add top-level test command
f12f024
@ofek
add to CI
89d1892
@ofek @StephenWakely
Apply suggestions from code review
25f08a8 
Co-authored-by: Stephen Wakely <[email protected]>
@ofek
final update
953937b
@bruceg
Merge remote-tracking branch 'origin/master' into vdev
24f37f6
@bruceg
Fix clippy lints
2952ffe
@bruceg
Convert extensions to process::Command into an extension trait
6deaee8
@bruceg
Add infer_subcommands option and unabbreviate int subcommand
5053beb
@ofek
address
5b68809
@bruceg
Merge remote-tracking branch 'ofek/vdev' into bruceg/vdev
df850d0
@bruceg
Flatten out the cli.rs files
790aa9a
@bruceg
Inline the used cfg options
15c6d6c
@bruceg
Drop unused config bits
a38d183
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. domain: dev Anything related to Vector's development environment labels Jan 5, 2023
@bruceg bruceg requested a review from a team January 5, 2023 17:26
@netlify
Copy link

netlify bot commented Jan 5, 2023 •
edited
Loading

✅ Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 75c2f60
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63b8a2d2f8b72b0008196e59

@netlify
Copy link

netlify bot commented Jan 5, 2023 •
edited
Loading

✅ Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 75c2f60
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63b8a2d25092de000a056c08

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Regression Test Results

Run ID: de87efa1-824a-4f50-b22b-320481f6a55f
Baseline: b56193e
Comparison: a38d183
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

Changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

experiment Δ mean Δ mean % confidence
syslog_log2metric_splunk_hec_metrics -554.2KiB/CPU-s -5.73 100.00%
http_text_to_http_json -2.31MiB/CPU-s -9.16 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole_acks 782.37KiB/CPU-s 2.5 100.00% 30.56MiB/CPU-s 1.84MiB/CPU-s 24.27KiB/CPU-s 0.0 0.060074 31.32MiB/CPU-s 1.16MiB/CPU-s 15.32KiB/CPU-s 0.0 0.037009 False False
datadog_agent_remap_blackhole 540.72KiB/CPU-s 1.75 100.00% 30.13MiB/CPU-s 1.62MiB/CPU-s 21.44KiB/CPU-s 0.0 0.053832 30.65MiB/CPU-s 1.6MiB/CPU-s 21.12KiB/CPU-s 0.0 0.052116 False False
syslog_log2metric_humio_metrics 85.59KiB/CPU-s 1.42 100.00% 5.88MiB/CPU-s 298.39KiB/CPU-s 3.85KiB/CPU-s 0.0 0.049535 5.97MiB/CPU-s 202.47KiB/CPU-s 2.61KiB/CPU-s 0.0 0.033141 False False
splunk_hec_route_s3 86.95KiB/CPU-s 0.74 100.00% 11.54MiB/CPU-s 674.61KiB/CPU-s 8.7KiB/CPU-s 0.0 0.057098 11.62MiB/CPU-s 620.58KiB/CPU-s 8.01KiB/CPU-s 0.0 0.052141 False False
syslog_loki 30.87KiB/CPU-s 0.36 99.98% 8.39MiB/CPU-s 618.7KiB/CPU-s 7.99KiB/CPU-s 0.0 0.07198 8.42MiB/CPU-s 167.97KiB/CPU-s 2.17KiB/CPU-s 0.0 0.019472 False False
enterprise_http_to_http 8.51KiB/CPU-s 0.06 89.94% 13.61MiB/CPU-s 331.59KiB/CPU-s 4.28KiB/CPU-s 0.0 0.023787 13.62MiB/CPU-s 226.9KiB/CPU-s 2.93KiB/CPU-s 0.0 0.016267 False False
splunk_hec_to_splunk_hec_logs_noack 5.51KiB/CPU-s 0.04 83.61% 13.62MiB/CPU-s 238.77KiB/CPU-s 3.08KiB/CPU-s 0.0 0.017119 13.63MiB/CPU-s 192.05KiB/CPU-s 2.48KiB/CPU-s 0.0 0.013764 False False
splunk_hec_to_splunk_hec_logs_acks 1.71KiB/CPU-s 0.01 20.65% 13.61MiB/CPU-s 358.13KiB/CPU-s 4.62KiB/CPU-s 0.0 0.025687 13.62MiB/CPU-s 357.77KiB/CPU-s 4.62KiB/CPU-s 0.0 0.025658 False False
fluent_elasticsearch -214.11B/CPU-s -0.0 29.80% 45.41MiB/CPU-s 30.29KiB/CPU-s 395.86B/CPU-s 0.0 0.000651 45.41MiB/CPU-s 30.27KiB/CPU-s 395.62B/CPU-s 0.0 0.000651 False False
splunk_hec_indexer_ack_blackhole -194.71B/CPU-s -0.0 3.33% 13.62MiB/CPU-s 250.18KiB/CPU-s 3.23KiB/CPU-s 0.0 0.01794 13.62MiB/CPU-s 248.4KiB/CPU-s 3.2KiB/CPU-s 0.0 0.017813 False False
file_to_blackhole -9.8KiB/CPU-s -0.02 34.22% 54.49MiB/CPU-s 1.13MiB/CPU-s 14.9KiB/CPU-s 0.0 0.020703 54.49MiB/CPU-s 1.24MiB/CPU-s 16.36KiB/CPU-s 0.0 0.022735 False False
http_to_http_noack -3.78KiB/CPU-s -0.03 53.84% 13.62MiB/CPU-s 259.81KiB/CPU-s 3.35KiB/CPU-s 0.0 0.018629 13.61MiB/CPU-s 301.52KiB/CPU-s 3.89KiB/CPU-s 0.0 0.021626 False False
http_to_http_acks -27.93KiB/CPU-s -0.52 41.16% 5.26MiB/CPU-s 2.78MiB/CPU-s 36.75KiB/CPU-s 0.0 0.528369 5.24MiB/CPU-s 2.74MiB/CPU-s 36.23KiB/CPU-s 0.0 0.523662 True False
http_to_http_json -71.98KiB/CPU-s -0.52 100.00% 13.55MiB/CPU-s 350.48KiB/CPU-s 4.52KiB/CPU-s 0.0 0.025266 13.48MiB/CPU-s 388.76KiB/CPU-s 5.01KiB/CPU-s 0.0 0.028172 False False
syslog_regex_logs2metric_ddmetrics -64.93KiB/CPU-s -1.72 100.00% 3.68MiB/CPU-s 461.56KiB/CPU-s 5.96KiB/CPU-s 0.0 0.122609 3.61MiB/CPU-s 486.26KiB/CPU-s 6.28KiB/CPU-s 0.0 0.131438 True False
otlp_http_to_blackhole -31.83KiB/CPU-s -2.03 100.00% 1.53MiB/CPU-s 112.61KiB/CPU-s 1.45KiB/CPU-s 0.0 0.07169 1.5MiB/CPU-s 130.74KiB/CPU-s 1.69KiB/CPU-s 0.0 0.084958 False False
otlp_grpc_to_blackhole -29.0KiB/CPU-s -2.71 100.00% 1.05MiB/CPU-s 36.53KiB/CPU-s 482.88B/CPU-s 0.0 0.034113 1.02MiB/CPU-s 52.64KiB/CPU-s 695.56B/CPU-s 0.0 0.050532 False False
socket_to_socket_blackhole -394.67KiB/CPU-s -2.84 100.00% 13.57MiB/CPU-s 305.32KiB/CPU-s 3.94KiB/CPU-s 0.0 0.021974 13.18MiB/CPU-s 255.22KiB/CPU-s 3.3KiB/CPU-s 0.0 0.018905 False False
datadog_agent_remap_datadog_logs -1.25MiB/CPU-s -3.66 100.00% 34.14MiB/CPU-s 1.4MiB/CPU-s 18.47KiB/CPU-s 0.0 0.040962 32.89MiB/CPU-s 1.72MiB/CPU-s 22.66KiB/CPU-s 0.0 0.052152 False False
syslog_splunk_hec_logs -360.37KiB/CPU-s -3.88 100.00% 9.06MiB/CPU-s 255.51KiB/CPU-s 3.3KiB/CPU-s 0.0 0.027525 8.71MiB/CPU-s 272.41KiB/CPU-s 3.51KiB/CPU-s 0.0 0.030532 False False
syslog_humio_logs -392.31KiB/CPU-s -4.19 100.00% 9.14MiB/CPU-s 265.02KiB/CPU-s 3.42KiB/CPU-s 0.0 0.028306 8.76MiB/CPU-s 188.99KiB/CPU-s 2.44KiB/CPU-s 0.0 0.021068 False False
datadog_agent_remap_datadog_logs_acks -1.47MiB/CPU-s -4.24 100.00% 34.63MiB/CPU-s 791.86KiB/CPU-s 10.22KiB/CPU-s 0.0 0.022326 33.17MiB/CPU-s 1.09MiB/CPU-s 14.43KiB/CPU-s 0.0 0.032913 False False
syslog_log2metric_splunk_hec_metrics -554.2KiB/CPU-s -5.73 100.00% 9.45MiB/CPU-s 386.33KiB/CPU-s 4.99KiB/CPU-s 0.0 0.03992 8.91MiB/CPU-s 358.03KiB/CPU-s 4.62KiB/CPU-s 0.0 0.039243 False False
http_text_to_http_json -2.31MiB/CPU-s -9.16 100.00% 25.22MiB/CPU-s 548.11KiB/CPU-s 7.07KiB/CPU-s 0.0 0.021219 22.91MiB/CPU-s 806.86KiB/CPU-s 10.41KiB/CPU-s 0.0 0.034385 False False

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Regression Test Results

Run ID: 1ae606d2-60f7-48ea-9a0a-44b17786dc8b
Baseline: bca52c3
Comparison: 8e6cde0
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

Changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

experiment Δ mean Δ mean % confidence
http_text_to_http_json -1.23MiB/CPU-s -5.05 100.00%
syslog_humio_logs -497.07KiB/CPU-s -5.34 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics 25.49KiB/CPU-s 0.68 99.54% 3.67MiB/CPU-s 517.77KiB/CPU-s 6.68KiB/CPU-s 0.0 0.137817 3.69MiB/CPU-s 466.79KiB/CPU-s 6.03KiB/CPU-s 0.0 0.12341 True False
http_to_http_acks 18.08KiB/CPU-s 0.34 27.14% 5.25MiB/CPU-s 2.82MiB/CPU-s 37.21KiB/CPU-s 0.0 0.535915 5.27MiB/CPU-s 2.76MiB/CPU-s 36.5KiB/CPU-s 0.0 0.523986 True False
datadog_agent_remap_blackhole 101.86KiB/CPU-s 0.32 100.00% 30.71MiB/CPU-s 1.19MiB/CPU-s 15.67KiB/CPU-s 0.0 0.038583 30.81MiB/CPU-s 636.25KiB/CPU-s 8.22KiB/CPU-s 0.0 0.020165 False False
syslog_log2metric_humio_metrics 5.6KiB/CPU-s 0.09 59.04% 5.77MiB/CPU-s 363.43KiB/CPU-s 4.69KiB/CPU-s 0.0 0.061546 5.77MiB/CPU-s 380.39KiB/CPU-s 4.91KiB/CPU-s 0.0 0.064358 False False
enterprise_http_to_http 12.45KiB/CPU-s 0.09 99.18% 13.61MiB/CPU-s 332.99KiB/CPU-s 4.3KiB/CPU-s 0.0 0.023888 13.62MiB/CPU-s 149.43KiB/CPU-s 1.93KiB/CPU-s 0.0 0.01071 False False
otlp_http_to_blackhole 832.49B/CPU-s 0.05 28.82% 1.53MiB/CPU-s 119.64KiB/CPU-s 1.54KiB/CPU-s 0.0 0.076214 1.53MiB/CPU-s 121.57KiB/CPU-s 1.57KiB/CPU-s 0.0 0.077402 False False
http_to_http_noack 6.22KiB/CPU-s 0.04 74.67% 13.61MiB/CPU-s 333.28KiB/CPU-s 4.3KiB/CPU-s 0.0 0.023909 13.62MiB/CPU-s 259.04KiB/CPU-s 3.34KiB/CPU-s 0.0 0.018575 False False
splunk_hec_to_splunk_hec_logs_noack 4.61KiB/CPU-s 0.03 77.06% 13.62MiB/CPU-s 227.01KiB/CPU-s 2.93KiB/CPU-s 0.0 0.016275 13.63MiB/CPU-s 191.86KiB/CPU-s 2.48KiB/CPU-s 0.0 0.01375 False False
splunk_hec_to_splunk_hec_logs_acks 3.18KiB/CPU-s 0.02 35.52% 13.61MiB/CPU-s 386.18KiB/CPU-s 4.98KiB/CPU-s 0.0 0.0277 13.62MiB/CPU-s 370.46KiB/CPU-s 4.78KiB/CPU-s 0.0 0.026566 False False
fluent_elasticsearch -81.74B/CPU-s -0.0 5.62% 45.41MiB/CPU-s 75.1KiB/CPU-s 980.72B/CPU-s 0.0 0.001615 45.41MiB/CPU-s 47.29KiB/CPU-s 617.83B/CPU-s 0.0 0.001017 False False
splunk_hec_indexer_ack_blackhole -909.42B/CPU-s -0.01 15.60% 13.62MiB/CPU-s 244.32KiB/CPU-s 3.15KiB/CPU-s 0.0 0.017519 13.62MiB/CPU-s 250.5KiB/CPU-s 3.23KiB/CPU-s 0.0 0.017963 False False
splunk_hec_route_s3 -915.34B/CPU-s -0.01 6.33% 11.64MiB/CPU-s 628.84KiB/CPU-s 8.11KiB/CPU-s 0.0 0.052736 11.64MiB/CPU-s 603.84KiB/CPU-s 7.79KiB/CPU-s 0.0 0.050644 False False
file_to_blackhole -4.79KiB/CPU-s -0.01 16.79% 54.49MiB/CPU-s 1.17MiB/CPU-s 15.42KiB/CPU-s 0.0 0.021414 54.49MiB/CPU-s 1.25MiB/CPU-s 16.53KiB/CPU-s 0.0 0.02298 False False
http_to_http_json -34.25KiB/CPU-s -0.25 100.00% 13.62MiB/CPU-s 210.55KiB/CPU-s 2.72KiB/CPU-s 0.0 0.015092 13.59MiB/CPU-s 272.7KiB/CPU-s 3.52KiB/CPU-s 0.0 0.019596 False False
syslog_splunk_hec_logs -90.11KiB/CPU-s -0.98 100.00% 8.96MiB/CPU-s 552.08KiB/CPU-s 7.13KiB/CPU-s 0.0 0.060197 8.87MiB/CPU-s 181.56KiB/CPU-s 2.34KiB/CPU-s 0.0 0.019993 False False
datadog_agent_remap_datadog_logs -351.95KiB/CPU-s -1.05 100.00% 32.75MiB/CPU-s 1.92MiB/CPU-s 25.38KiB/CPU-s 0.0 0.058652 32.41MiB/CPU-s 1.78MiB/CPU-s 23.52KiB/CPU-s 0.0 0.054941 False False
datadog_agent_remap_blackhole_acks -462.62KiB/CPU-s -1.45 100.00% 31.07MiB/CPU-s 935.01KiB/CPU-s 12.07KiB/CPU-s 0.0 0.029387 30.62MiB/CPU-s 996.54KiB/CPU-s 12.87KiB/CPU-s 0.0 0.031783 False False
syslog_loki -189.13KiB/CPU-s -2.23 100.00% 8.28MiB/CPU-s 479.69KiB/CPU-s 6.19KiB/CPU-s 0.0 0.056601 8.09MiB/CPU-s 418.33KiB/CPU-s 5.4KiB/CPU-s 0.0 0.050487 False False
socket_to_socket_blackhole -351.97KiB/CPU-s -2.56 100.00% 13.45MiB/CPU-s 387.98KiB/CPU-s 5.01KiB/CPU-s 0.0 0.028162 13.11MiB/CPU-s 319.41KiB/CPU-s 4.13KiB/CPU-s 0.0 0.023793 False False
datadog_agent_remap_datadog_logs_acks -1.26MiB/CPU-s -3.74 100.00% 33.67MiB/CPU-s 1.39MiB/CPU-s 18.36KiB/CPU-s 0.0 0.041252 32.41MiB/CPU-s 1.26MiB/CPU-s 16.62KiB/CPU-s 0.0 0.038791 False False
syslog_log2metric_splunk_hec_metrics -435.83KiB/CPU-s -4.61 100.00% 9.23MiB/CPU-s 496.74KiB/CPU-s 6.41KiB/CPU-s 0.0 0.052577 8.8MiB/CPU-s 732.12KiB/CPU-s 9.45KiB/CPU-s 0.0 0.081239 False False
otlp_grpc_to_blackhole -50.09KiB/CPU-s -4.66 100.00% 1.05MiB/CPU-s 44.57KiB/CPU-s 589.02B/CPU-s 0.0 0.041489 1.0MiB/CPU-s 55.5KiB/CPU-s 733.37B/CPU-s 0.0 0.054193 False False
http_text_to_http_json -1.23MiB/CPU-s -5.05 100.00% 24.34MiB/CPU-s 1.24MiB/CPU-s 16.37KiB/CPU-s 0.0 0.050885 23.11MiB/CPU-s 1.13MiB/CPU-s 14.91KiB/CPU-s 0.0 0.048819 False False
syslog_humio_logs -497.07KiB/CPU-s -5.34 100.00% 9.1MiB/CPU-s 360.31KiB/CPU-s 4.65KiB/CPU-s 0.0 0.03867 8.61MiB/CPU-s 326.64KiB/CPU-s 4.22KiB/CPU-s 0.0 0.037032 False False

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Regression Test Results

Run ID: 2b3da760-326b-43e1-a3f8-5574a14aaaf2
Baseline: bca52c3
Comparison: e998ee2
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

Changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

experiment Δ mean Δ mean % confidence
datadog_agent_remap_datadog_logs_acks -1.88MiB/CPU-s -5.63 100.00%
syslog_humio_logs -625.79KiB/CPU-s -6.56 100.00%
http_text_to_http_json -1.66MiB/CPU-s -6.61 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics 75.25KiB/CPU-s 2.13 100.00% 3.44MiB/CPU-s 445.75KiB/CPU-s 5.75KiB/CPU-s 0.0 0.126404 3.52MiB/CPU-s 476.47KiB/CPU-s 6.15KiB/CPU-s 0.0 0.132293 True False
syslog_log2metric_humio_metrics 46.21KiB/CPU-s 0.76 100.00% 5.9MiB/CPU-s 278.98KiB/CPU-s 3.6KiB/CPU-s 0.0 0.046152 5.95MiB/CPU-s 220.99KiB/CPU-s 2.85KiB/CPU-s 0.0 0.036281 False False
splunk_hec_to_splunk_hec_logs_acks 20.66KiB/CPU-s 0.15 99.77% 13.61MiB/CPU-s 365.97KiB/CPU-s 4.72KiB/CPU-s 0.0 0.02625 13.63MiB/CPU-s 377.33KiB/CPU-s 4.87KiB/CPU-s 0.0 0.027024 False False
enterprise_http_to_http 11.91KiB/CPU-s 0.09 97.12% 13.61MiB/CPU-s 355.48KiB/CPU-s 4.59KiB/CPU-s 0.0 0.025505 13.62MiB/CPU-s 228.1KiB/CPU-s 2.94KiB/CPU-s 0.0 0.016352 False False
datadog_agent_remap_blackhole_acks 18.32KiB/CPU-s 0.06 63.34% 31.36MiB/CPU-s 1.19MiB/CPU-s 15.67KiB/CPU-s 0.0 0.037792 31.38MiB/CPU-s 998.11KiB/CPU-s 12.89KiB/CPU-s 0.0 0.031059 False False
http_to_http_noack 4.11KiB/CPU-s 0.03 57.06% 13.61MiB/CPU-s 308.34KiB/CPU-s 3.98KiB/CPU-s 0.0 0.022116 13.62MiB/CPU-s 259.49KiB/CPU-s 3.35KiB/CPU-s 0.0 0.018607 False False
splunk_hec_to_splunk_hec_logs_noack 3.26KiB/CPU-s 0.02 61.15% 13.62MiB/CPU-s 220.63KiB/CPU-s 2.85KiB/CPU-s 0.0 0.015816 13.63MiB/CPU-s 192.51KiB/CPU-s 2.49KiB/CPU-s 0.0 0.013796 False False
splunk_hec_indexer_ack_blackhole 1.11KiB/CPU-s 0.01 19.42% 13.62MiB/CPU-s 253.63KiB/CPU-s 3.27KiB/CPU-s 0.0 0.018188 13.62MiB/CPU-s 242.38KiB/CPU-s 3.13KiB/CPU-s 0.0 0.01738 False False
file_to_blackhole 2.01KiB/CPU-s 0.0 7.46% 54.49MiB/CPU-s 1.07MiB/CPU-s 14.19KiB/CPU-s 0.0 0.01972 54.49MiB/CPU-s 1.22MiB/CPU-s 16.05KiB/CPU-s 0.0 0.022318 False False
fluent_elasticsearch 314.01B/CPU-s 0.0 42.22% 45.41MiB/CPU-s 30.59KiB/CPU-s 399.85B/CPU-s 0.0 0.000658 45.41MiB/CPU-s 30.46KiB/CPU-s 398.05B/CPU-s 0.0 0.000655 False False
otlp_http_to_blackhole -6.04KiB/CPU-s -0.38 99.61% 1.53MiB/CPU-s 108.1KiB/CPU-s 1.4KiB/CPU-s 0.0 0.068808 1.53MiB/CPU-s 120.69KiB/CPU-s 1.56KiB/CPU-s 0.0 0.077121 False False
http_to_http_json -57.59KiB/CPU-s -0.41 100.00% 13.62MiB/CPU-s 221.56KiB/CPU-s 2.86KiB/CPU-s 0.0 0.015886 13.56MiB/CPU-s 301.21KiB/CPU-s 3.89KiB/CPU-s 0.0 0.021686 False False
splunk_hec_route_s3 -87.61KiB/CPU-s -0.73 100.00% 11.71MiB/CPU-s 681.84KiB/CPU-s 8.8KiB/CPU-s 0.0 0.056836 11.63MiB/CPU-s 666.58KiB/CPU-s 8.6KiB/CPU-s 0.0 0.055973 False False
syslog_loki -143.24KiB/CPU-s -1.67 100.00% 8.4MiB/CPU-s 455.32KiB/CPU-s 5.88KiB/CPU-s 0.0 0.052955 8.26MiB/CPU-s 299.67KiB/CPU-s 3.87KiB/CPU-s 0.0 0.035443 False False
http_to_http_acks -108.11KiB/CPU-s -2.0 96.48% 5.29MiB/CPU-s 2.76MiB/CPU-s 36.42KiB/CPU-s 0.0 0.521023 5.18MiB/CPU-s 2.74MiB/CPU-s 36.17KiB/CPU-s 0.0 0.527861 True False
otlp_grpc_to_blackhole -22.22KiB/CPU-s -2.08 100.00% 1.04MiB/CPU-s 45.49KiB/CPU-s 601.24B/CPU-s 0.0 0.042669 1.02MiB/CPU-s 55.91KiB/CPU-s 738.66B/CPU-s 0.0 0.05356 False False
syslog_splunk_hec_logs -217.18KiB/CPU-s -2.34 100.00% 9.05MiB/CPU-s 328.48KiB/CPU-s 4.24KiB/CPU-s 0.0 0.035429 8.84MiB/CPU-s 177.59KiB/CPU-s 2.29KiB/CPU-s 0.0 0.019613 False False
syslog_log2metric_splunk_hec_metrics -253.73KiB/CPU-s -2.67 100.00% 9.28MiB/CPU-s 497.7KiB/CPU-s 6.43KiB/CPU-s 0.0 0.052344 9.04MiB/CPU-s 341.69KiB/CPU-s 4.41KiB/CPU-s 0.0 0.036922 False False
datadog_agent_remap_blackhole -944.0KiB/CPU-s -2.96 100.00% 31.2MiB/CPU-s 1.38MiB/CPU-s 18.23KiB/CPU-s 0.0 0.044212 30.27MiB/CPU-s 1.38MiB/CPU-s 18.26KiB/CPU-s 0.0 0.045628 False False
datadog_agent_remap_datadog_logs -1.09MiB/CPU-s -3.18 100.00% 34.4MiB/CPU-s 1.2MiB/CPU-s 15.9KiB/CPU-s 0.0 0.034992 33.3MiB/CPU-s 1.33MiB/CPU-s 17.6KiB/CPU-s 0.0 0.040012 False False
socket_to_socket_blackhole -470.69KiB/CPU-s -3.4 100.00% 13.52MiB/CPU-s 320.93KiB/CPU-s 4.14KiB/CPU-s 0.0 0.023186 13.06MiB/CPU-s 237.55KiB/CPU-s 3.07KiB/CPU-s 0.0 0.017766 False False
datadog_agent_remap_datadog_logs_acks -1.88MiB/CPU-s -5.63 100.00% 33.44MiB/CPU-s 1.55MiB/CPU-s 20.53KiB/CPU-s 0.0 0.046451 31.56MiB/CPU-s 1.92MiB/CPU-s 25.33KiB/CPU-s 0.0 0.060722 False False
syslog_humio_logs -625.79KiB/CPU-s -6.56 100.00% 9.31MiB/CPU-s 145.35KiB/CPU-s 1.88KiB/CPU-s 0.0 0.015238 8.7MiB/CPU-s 232.76KiB/CPU-s 3.0KiB/CPU-s 0.0 0.026116 False False
http_text_to_http_json -1.66MiB/CPU-s -6.61 100.00% 25.13MiB/CPU-s 579.95KiB/CPU-s 7.49KiB/CPU-s 0.0 0.022539 23.47MiB/CPU-s 691.32KiB/CPU-s 8.92KiB/CPU-s 0.0 0.028767 False False

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Regression Test Results

Run ID: e95bc33f-3814-479d-baf8-2369bea173e8
Baseline: 65cb0c5
Comparison: e21ec11
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_humio_logs 248.79KiB/CPU-s 2.77 100.00% 8.78MiB/CPU-s 366.0KiB/CPU-s 4.73KiB/CPU-s 0.0 0.040699 9.02MiB/CPU-s 275.62KiB/CPU-s 3.56KiB/CPU-s 0.0 0.029824 False False
syslog_loki 179.83KiB/CPU-s 2.05 100.00% 8.56MiB/CPU-s 291.35KiB/CPU-s 3.76KiB/CPU-s 0.0 0.03323 8.74MiB/CPU-s 83.3KiB/CPU-s 1.08KiB/CPU-s 0.0 0.00931 False False
syslog_log2metric_humio_metrics 80.81KiB/CPU-s 1.35 100.00% 5.86MiB/CPU-s 219.18KiB/CPU-s 2.83KiB/CPU-s 0.0 0.036494 5.94MiB/CPU-s 316.97KiB/CPU-s 4.09KiB/CPU-s 0.0 0.052074 False False
socket_to_socket_blackhole 114.98KiB/CPU-s 0.83 100.00% 13.55MiB/CPU-s 347.84KiB/CPU-s 4.49KiB/CPU-s 0.0 0.02506 13.67MiB/CPU-s 86.18KiB/CPU-s 1.11KiB/CPU-s 0.0 0.006158 False False
syslog_regex_logs2metric_ddmetrics 25.64KiB/CPU-s 0.7 99.96% 3.6MiB/CPU-s 405.31KiB/CPU-s 5.23KiB/CPU-s 0.0 0.109916 3.63MiB/CPU-s 394.07KiB/CPU-s 5.09KiB/CPU-s 0.0 0.106129 True False
datadog_agent_remap_blackhole 205.89KiB/CPU-s 0.64 100.00% 31.23MiB/CPU-s 1.08MiB/CPU-s 14.22KiB/CPU-s 0.0 0.034425 31.43MiB/CPU-s 844.21KiB/CPU-s 10.9KiB/CPU-s 0.0 0.026231 False False
datadog_agent_remap_datadog_logs_acks 210.26KiB/CPU-s 0.59 100.00% 34.6MiB/CPU-s 1.01MiB/CPU-s 13.32KiB/CPU-s 0.0 0.029144 34.8MiB/CPU-s 731.11KiB/CPU-s 9.44KiB/CPU-s 0.0 0.020514 False False
splunk_hec_to_splunk_hec_logs_noack 7.26KiB/CPU-s 0.05 93.07% 13.62MiB/CPU-s 245.93KiB/CPU-s 3.17KiB/CPU-s 0.0 0.017635 13.62MiB/CPU-s 188.36KiB/CPU-s 2.43KiB/CPU-s 0.0 0.0135 False False
enterprise_http_to_http 6.13KiB/CPU-s 0.04 83.25% 13.62MiB/CPU-s 285.25KiB/CPU-s 3.68KiB/CPU-s 0.0 0.020457 13.62MiB/CPU-s 191.86KiB/CPU-s 2.48KiB/CPU-s 0.0 0.013754 False False
http_to_http_noack 2.07KiB/CPU-s 0.01 29.69% 13.61MiB/CPU-s 309.9KiB/CPU-s 4.0KiB/CPU-s 0.0 0.022229 13.62MiB/CPU-s 284.41KiB/CPU-s 3.67KiB/CPU-s 0.0 0.020397 False False
splunk_hec_indexer_ack_blackhole 1.2KiB/CPU-s 0.01 20.40% 13.62MiB/CPU-s 256.48KiB/CPU-s 3.31KiB/CPU-s 0.0 0.018394 13.62MiB/CPU-s 251.51KiB/CPU-s 3.24KiB/CPU-s 0.0 0.018036 False False
splunk_hec_to_splunk_hec_logs_acks 609.53B/CPU-s 0.0 7.49% 13.62MiB/CPU-s 342.94KiB/CPU-s 4.42KiB/CPU-s 0.0 0.024596 13.62MiB/CPU-s 351.13KiB/CPU-s 4.53KiB/CPU-s 0.0 0.025182 False False
fluent_elasticsearch 387.35B/CPU-s 0.0 51.34% 45.41MiB/CPU-s 30.14KiB/CPU-s 394.23B/CPU-s 0.0 0.000648 45.41MiB/CPU-s 30.06KiB/CPU-s 393.21B/CPU-s 0.0 0.000646 False False
file_to_blackhole -9.55KiB/CPU-s -0.02 33.52% 54.5MiB/CPU-s 1.18MiB/CPU-s 15.57KiB/CPU-s 0.0 0.021631 54.49MiB/CPU-s 1.18MiB/CPU-s 15.58KiB/CPU-s 0.0 0.021668 False False
http_text_to_http_json -66.75KiB/CPU-s -0.26 100.00% 25.18MiB/CPU-s 557.05KiB/CPU-s 7.19KiB/CPU-s 0.0 0.021603 25.11MiB/CPU-s 702.35KiB/CPU-s 9.06KiB/CPU-s 0.0 0.027309 False False
syslog_splunk_hec_logs -38.55KiB/CPU-s -0.42 100.00% 9.02MiB/CPU-s 253.02KiB/CPU-s 3.27KiB/CPU-s 0.0 0.027383 8.98MiB/CPU-s 325.33KiB/CPU-s 4.2KiB/CPU-s 0.0 0.035356 False False
http_to_http_acks -22.94KiB/CPU-s -0.43 34.25% 5.23MiB/CPU-s 2.81MiB/CPU-s 37.12KiB/CPU-s 0.0 0.536684 5.21MiB/CPU-s 2.73MiB/CPU-s 36.04KiB/CPU-s 0.0 0.523341 True False
otlp_grpc_to_blackhole -5.5KiB/CPU-s -0.51 100.00% 1.04MiB/CPU-s 39.13KiB/CPU-s 517.26B/CPU-s 0.0 0.036636 1.04MiB/CPU-s 52.46KiB/CPU-s 693.22B/CPU-s 0.0 0.049374 False False
http_to_http_json -102.85KiB/CPU-s -0.74 100.00% 13.62MiB/CPU-s 209.17KiB/CPU-s 2.7KiB/CPU-s 0.0 0.014993 13.52MiB/CPU-s 363.82KiB/CPU-s 4.69KiB/CPU-s 0.0 0.026273 False False
datadog_agent_remap_blackhole_acks -276.93KiB/CPU-s -0.84 100.00% 32.29MiB/CPU-s 382.89KiB/CPU-s 4.94KiB/CPU-s 0.0 0.01158 32.02MiB/CPU-s 997.28KiB/CPU-s 12.87KiB/CPU-s 0.0 0.030417 False False
otlp_http_to_blackhole -16.4KiB/CPU-s -1.04 100.00% 1.54MiB/CPU-s 116.5KiB/CPU-s 1.5KiB/CPU-s 0.0 0.073665 1.53MiB/CPU-s 124.02KiB/CPU-s 1.6KiB/CPU-s 0.0 0.079241 False False
splunk_hec_route_s3 -125.45KiB/CPU-s -1.05 100.00% 11.71MiB/CPU-s 696.99KiB/CPU-s 8.99KiB/CPU-s 0.0 0.05811 11.59MiB/CPU-s 714.93KiB/CPU-s 9.23KiB/CPU-s 0.0 0.060236 False False
datadog_agent_remap_datadog_logs -1.37MiB/CPU-s -3.98 100.00% 34.4MiB/CPU-s 1.24MiB/CPU-s 16.34KiB/CPU-s 0.0 0.03596 33.03MiB/CPU-s 1.75MiB/CPU-s 23.14KiB/CPU-s 0.0 0.053032 False False
syslog_log2metric_splunk_hec_metrics -428.09KiB/CPU-s -4.46 100.00% 9.37MiB/CPU-s 232.23KiB/CPU-s 3.0KiB/CPU-s 0.0 0.024198 8.95MiB/CPU-s 334.98KiB/CPU-s 4.32KiB/CPU-s 0.0 0.036535 False False

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Regression Test Results

Run ID: 91eac73d-7111-4f8a-9656-2e87abeb174a
Baseline: eda64e7
Comparison: 75c2f60
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics 83.96KiB/CPU-s 2.33 100.00% 3.51MiB/CPU-s 364.9KiB/CPU-s 4.71KiB/CPU-s 0.0 0.101469 3.59MiB/CPU-s 515.59KiB/CPU-s 6.66KiB/CPU-s 0.0 0.140099 True False
syslog_log2metric_splunk_hec_metrics 184.58KiB/CPU-s 1.98 100.00% 9.12MiB/CPU-s 462.94KiB/CPU-s 5.98KiB/CPU-s 0.0 0.049571 9.3MiB/CPU-s 389.45KiB/CPU-s 5.03KiB/CPU-s 0.0 0.040894 False False
socket_to_socket_blackhole 258.83KiB/CPU-s 1.91 100.00% 13.22MiB/CPU-s 397.95KiB/CPU-s 5.14KiB/CPU-s 0.0 0.029398 13.47MiB/CPU-s 310.66KiB/CPU-s 4.01KiB/CPU-s 0.0 0.022519 False False
datadog_agent_remap_datadog_logs 532.74KiB/CPU-s 1.56 100.00% 33.45MiB/CPU-s 1.69MiB/CPU-s 22.38KiB/CPU-s 0.0 0.050638 33.97MiB/CPU-s 1.26MiB/CPU-s 16.64KiB/CPU-s 0.0 0.037083 False False
http_text_to_http_json 290.06KiB/CPU-s 1.16 100.00% 24.44MiB/CPU-s 659.74KiB/CPU-s 8.52KiB/CPU-s 0.0 0.026355 24.73MiB/CPU-s 911.43KiB/CPU-s 11.76KiB/CPU-s 0.0 0.035993 False False
http_to_http_json 57.67KiB/CPU-s 0.42 100.00% 13.54MiB/CPU-s 359.11KiB/CPU-s 4.63KiB/CPU-s 0.0 0.025902 13.59MiB/CPU-s 252.97KiB/CPU-s 3.26KiB/CPU-s 0.0 0.018171 False False
datadog_agent_remap_datadog_logs_acks 119.89KiB/CPU-s 0.34 100.00% 34.05MiB/CPU-s 1.14MiB/CPU-s 15.04KiB/CPU-s 0.0 0.033433 34.17MiB/CPU-s 1.24MiB/CPU-s 16.34KiB/CPU-s 0.0 0.036187 False False
otlp_grpc_to_blackhole 3.29KiB/CPU-s 0.31 99.90% 1.03MiB/CPU-s 52.11KiB/CPU-s 688.77B/CPU-s 0.0 0.04959 1.03MiB/CPU-s 57.2KiB/CPU-s 755.78B/CPU-s 0.0 0.054272 False False
http_to_http_acks 8.0KiB/CPU-s 0.15 12.37% 5.23MiB/CPU-s 2.75MiB/CPU-s 36.32KiB/CPU-s 0.0 0.52578 5.23MiB/CPU-s 2.75MiB/CPU-s 36.32KiB/CPU-s 0.0 0.52511 True False
http_to_http_noack 6.12KiB/CPU-s 0.04 74.15% 13.61MiB/CPU-s 330.35KiB/CPU-s 4.26KiB/CPU-s 0.0 0.023699 13.62MiB/CPU-s 258.91KiB/CPU-s 3.34KiB/CPU-s 0.0 0.018566 False False
enterprise_http_to_http 3.88KiB/CPU-s 0.03 58.83% 13.62MiB/CPU-s 286.83KiB/CPU-s 3.7KiB/CPU-s 0.0 0.02057 13.62MiB/CPU-s 227.97KiB/CPU-s 2.94KiB/CPU-s 0.0 0.016345 False False
splunk_hec_to_splunk_hec_logs_noack 3.45KiB/CPU-s 0.02 64.59% 13.62MiB/CPU-s 217.45KiB/CPU-s 2.81KiB/CPU-s 0.0 0.015588 13.63MiB/CPU-s 189.46KiB/CPU-s 2.45KiB/CPU-s 0.0 0.013578 False False
splunk_hec_indexer_ack_blackhole 1.13KiB/CPU-s 0.01 18.97% 13.62MiB/CPU-s 257.97KiB/CPU-s 3.33KiB/CPU-s 0.0 0.018502 13.62MiB/CPU-s 257.96KiB/CPU-s 3.33KiB/CPU-s 0.0 0.018499 False False
fluent_elasticsearch 348.63B/CPU-s 0.0 46.89% 45.41MiB/CPU-s 30.01KiB/CPU-s 391.87B/CPU-s 0.0 0.000645 45.41MiB/CPU-s 30.25KiB/CPU-s 395.36B/CPU-s 0.0 0.00065 False False
splunk_hec_to_splunk_hec_logs_acks -997.28B/CPU-s -0.01 11.42% 13.62MiB/CPU-s 358.96KiB/CPU-s 4.63KiB/CPU-s 0.0 0.025744 13.61MiB/CPU-s 383.69KiB/CPU-s 4.95KiB/CPU-s 0.0 0.027519 False False
syslog_splunk_hec_logs -2.89KiB/CPU-s -0.03 46.76% 9.01MiB/CPU-s 256.32KiB/CPU-s 3.31KiB/CPU-s 0.0 0.02777 9.01MiB/CPU-s 251.4KiB/CPU-s 3.24KiB/CPU-s 0.0 0.027245 False False
file_to_blackhole -22.64KiB/CPU-s -0.04 69.47% 54.5MiB/CPU-s 1.12MiB/CPU-s 14.84KiB/CPU-s 0.0 0.020612 54.47MiB/CPU-s 1.24MiB/CPU-s 16.35KiB/CPU-s 0.0 0.022747 False False
syslog_humio_logs -14.81KiB/CPU-s -0.16 100.00% 9.18MiB/CPU-s 223.02KiB/CPU-s 2.88KiB/CPU-s 0.0 0.023712 9.17MiB/CPU-s 130.79KiB/CPU-s 1.69KiB/CPU-s 0.0 0.013928 False False
otlp_http_to_blackhole -4.61KiB/CPU-s -0.29 96.93% 1.54MiB/CPU-s 114.05KiB/CPU-s 1.47KiB/CPU-s 0.0 0.072262 1.54MiB/CPU-s 119.75KiB/CPU-s 1.54KiB/CPU-s 0.0 0.0761 False False
splunk_hec_route_s3 -69.45KiB/CPU-s -0.58 100.00% 11.71MiB/CPU-s 581.85KiB/CPU-s 7.51KiB/CPU-s 0.0 0.048502 11.65MiB/CPU-s 595.82KiB/CPU-s 7.69KiB/CPU-s 0.0 0.049956 False False
datadog_agent_remap_blackhole_acks -275.46KiB/CPU-s -0.88 100.00% 30.7MiB/CPU-s 2.03MiB/CPU-s 26.77KiB/CPU-s 0.0 0.065966 30.43MiB/CPU-s 1.67MiB/CPU-s 22.02KiB/CPU-s 0.0 0.054727 False False
datadog_agent_remap_blackhole -358.29KiB/CPU-s -1.11 100.00% 31.63MiB/CPU-s 739.31KiB/CPU-s 9.54KiB/CPU-s 0.0 0.022827 31.28MiB/CPU-s 1.38MiB/CPU-s 18.26KiB/CPU-s 0.0 0.044167 False False
syslog_log2metric_humio_metrics -118.03KiB/CPU-s -1.9 100.00% 6.07MiB/CPU-s 180.23KiB/CPU-s 2.33KiB/CPU-s 0.0 0.02899 5.96MiB/CPU-s 291.82KiB/CPU-s 3.77KiB/CPU-s 0.0 0.047848 False False
syslog_loki -184.74KiB/CPU-s -2.11 100.00% 8.55MiB/CPU-s 278.87KiB/CPU-s 3.6KiB/CPU-s 0.0 0.031862 8.37MiB/CPU-s 408.56KiB/CPU-s 5.27KiB/CPU-s 0.0 0.047686 False False

spencergilbert
spencergilbert approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I would note that this hardcodes the use of docker rather than allowing for docker or podman.

@bruceg
Copy link
Member Author

bruceg commented Jan 9, 2023

I know. That will be a target of follow-up work.

@bruceg bruceg merged commit 3694010 into master Jan 9, 2023
@bruceg bruceg deleted the bruceg/vdev branch January 9, 2023 21:02
@bruceg bruceg mentioned this pull request Jan 23, 2023
Closed
@tshepang
Copy link
Contributor

This is a follow-up to #14990 as @ofek does not have sufficient time to actively pursue this track now that he is no longer embedded. Most of the code is his, I have just closed some of the outstanding issues with it.

what does embedded mean

@jszwedko
Copy link
Member

This is a follow-up to #14990 as @ofek does not have sufficient time to actively pursue this track now that he is no longer embedded. Most of the code is his, I have just closed some of the outstanding issues with it.

what does embedded mean

Ah, yeah, that comment would be pretty inscrutable to people outside of Datadog :) It just means that Ofek was working on our team within Datadog for a bit but now is back on a different team.

@bruceg bruceg added the domain: vdev Anything related to the vdev tooling label Feb 10, 2023
@jszwedko jszwedko mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergilbert spencergilbert spencergilbert approved these changes

@lukesteensen lukesteensen lukesteensen approved these changes

@neuronull neuronull Awaiting requested review from neuronull

@StephenWakely StephenWakely Awaiting requested review from StephenWakely

Assignees
No one assigned
Labels
domain: dev Anything related to Vector's development environment domain: vdev Anything related to the vdev tooling type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bruceg @tshepang @jszwedko @lukesteensen @spencergilbert @ofek