Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(ClickHouse sink): Adding date_time_best_effort flag #15644

Closed
wants to merge 0 commits into from

Conversation

DarkWanderer
Copy link
Contributor

@DarkWanderer DarkWanderer commented Dec 20, 2022

Added support for ClickHouse setting which will allow to ingest timestamp with subsecond precision (DateTime64 column). This trades off some performance cost on server side for ability to store same timestamp precision as vector uses

Closes #1672

@bits-bot
Copy link

bits-bot commented Dec 20, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 21d3931
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63b187ec7a9c3c0008612194
😎 Deploy Preview https://deploy-preview-15644--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 21d3931
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63b187ec8632f90009c78770

@github-actions github-actions bot added domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks labels Dec 20, 2022
@DarkWanderer DarkWanderer changed the title Adding date_time_best_effort flag for ClickHouse sink enhancement(ClickHouse sink): Adding date_time_best_effort flag Dec 20, 2022
@github-actions github-actions bot removed domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks labels Jan 1, 2023
@DarkWanderer
Copy link
Contributor Author

Recreated as #15787 (should not have created this PR from master)

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Regression Test Results

Run ID: aee6097f-bb6e-4294-b862-f42433e295d8
Baseline: bfad266
Comparison: 652862b
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
socket_to_socket_blackhole 476.02KiB/CPU-s 3.61 100.00% 12.87MiB/CPU-s 325.81KiB/CPU-s 4.21KiB/CPU-s 0.0 0.024721 13.33MiB/CPU-s 76.69KiB/CPU-s 1014.29B/CPU-s 0.0 0.005616 False False
syslog_loki 260.15KiB/CPU-s 3.08 100.00% 8.25MiB/CPU-s 281.13KiB/CPU-s 3.63KiB/CPU-s 0.0 0.033282 8.5MiB/CPU-s 95.41KiB/CPU-s 1.23KiB/CPU-s 0.0 0.010958 False False
otlp_http_to_blackhole 33.18KiB/CPU-s 2.19 100.00% 1.48MiB/CPU-s 124.77KiB/CPU-s 1.61KiB/CPU-s 0.0 0.082266 1.51MiB/CPU-s 126.55KiB/CPU-s 1.63KiB/CPU-s 0.0 0.081657 False False
syslog_splunk_hec_logs 106.61KiB/CPU-s 1.2 100.00% 8.67MiB/CPU-s 202.01KiB/CPU-s 2.61KiB/CPU-s 0.0 0.022754 8.77MiB/CPU-s 214.62KiB/CPU-s 2.77KiB/CPU-s 0.0 0.023887 False False
otlp_grpc_to_blackhole 11.13KiB/CPU-s 1.08 100.00% 1.01MiB/CPU-s 41.01KiB/CPU-s 542.11B/CPU-s 0.0 0.03974 1.02MiB/CPU-s 55.55KiB/CPU-s 733.84B/CPU-s 0.0 0.053256 False False
syslog_humio_logs 85.44KiB/CPU-s 0.96 100.00% 8.73MiB/CPU-s 297.26KiB/CPU-s 3.84KiB/CPU-s 0.0 0.033253 8.81MiB/CPU-s 188.1KiB/CPU-s 2.43KiB/CPU-s 0.0 0.020843 False False
datadog_agent_remap_datadog_logs 217.81KiB/CPU-s 0.64 100.00% 33.48MiB/CPU-s 1.46MiB/CPU-s 19.24KiB/CPU-s 0.0 0.043514 33.69MiB/CPU-s 1.11MiB/CPU-s 14.66KiB/CPU-s 0.0 0.032928 False False
syslog_log2metric_splunk_hec_metrics 45.25KiB/CPU-s 0.49 100.00% 8.97MiB/CPU-s 340.93KiB/CPU-s 4.4KiB/CPU-s 0.0 0.03713 9.01MiB/CPU-s 313.83KiB/CPU-s 4.05KiB/CPU-s 0.0 0.03401 False False
enterprise_http_to_http 5.79KiB/CPU-s 0.04 80.75% 13.62MiB/CPU-s 284.79KiB/CPU-s 3.68KiB/CPU-s 0.0 0.020424 13.62MiB/CPU-s 192.83KiB/CPU-s 2.49KiB/CPU-s 0.0 0.013823 False False
splunk_hec_to_splunk_hec_logs_noack 4.78KiB/CPU-s 0.03 78.11% 13.62MiB/CPU-s 230.11KiB/CPU-s 2.97KiB/CPU-s 0.0 0.016497 13.63MiB/CPU-s 193.93KiB/CPU-s 2.5KiB/CPU-s 0.0 0.013899 False False
splunk_hec_to_splunk_hec_logs_acks 799.53B/CPU-s 0.01 9.31% 13.61MiB/CPU-s 373.67KiB/CPU-s 4.82KiB/CPU-s 0.0 0.0268 13.62MiB/CPU-s 357.66KiB/CPU-s 4.61KiB/CPU-s 0.0 0.02565 False False
fluent_elasticsearch -126.35B/CPU-s -0.0 17.94% 45.41MiB/CPU-s 30.43KiB/CPU-s 397.77B/CPU-s 0.0 0.000654 45.41MiB/CPU-s 29.83KiB/CPU-s 390.11B/CPU-s 0.0 0.000641 False False
http_to_http_noack -25.19B/CPU-s -0.0 0.35% 13.61MiB/CPU-s 310.51KiB/CPU-s 4.01KiB/CPU-s 0.0 0.022272 13.61MiB/CPU-s 310.94KiB/CPU-s 4.01KiB/CPU-s 0.0 0.022303 False False
splunk_hec_indexer_ack_blackhole -1.47KiB/CPU-s -0.01 24.75% 13.62MiB/CPU-s 252.96KiB/CPU-s 3.26KiB/CPU-s 0.0 0.018139 13.62MiB/CPU-s 256.53KiB/CPU-s 3.31KiB/CPU-s 0.0 0.018397 False False
file_to_blackhole -24.02KiB/CPU-s -0.04 72.63% 54.5MiB/CPU-s 1.08MiB/CPU-s 14.3KiB/CPU-s 0.0 0.019865 54.48MiB/CPU-s 1.26MiB/CPU-s 16.63KiB/CPU-s 0.0 0.023141 False False
http_to_http_json -22.14KiB/CPU-s -0.16 100.00% 13.62MiB/CPU-s 207.84KiB/CPU-s 2.68KiB/CPU-s 0.0 0.014899 13.6MiB/CPU-s 283.66KiB/CPU-s 3.66KiB/CPU-s 0.0 0.020367 False False
splunk_hec_route_s3 -50.97KiB/CPU-s -0.42 100.00% 11.75MiB/CPU-s 542.51KiB/CPU-s 7.0KiB/CPU-s 0.0 0.045087 11.7MiB/CPU-s 634.63KiB/CPU-s 8.19KiB/CPU-s 0.0 0.052967 False False
http_to_http_acks -25.96KiB/CPU-s -0.48 38.91% 5.23MiB/CPU-s 2.76MiB/CPU-s 36.5KiB/CPU-s 0.0 0.527872 5.21MiB/CPU-s 2.7MiB/CPU-s 35.67KiB/CPU-s 0.0 0.518451 True False
datadog_agent_remap_datadog_logs_acks -198.46KiB/CPU-s -0.58 100.00% 33.47MiB/CPU-s 1.23MiB/CPU-s 16.22KiB/CPU-s 0.0 0.036669 33.28MiB/CPU-s 1.02MiB/CPU-s 13.47KiB/CPU-s 0.0 0.030619 False False
datadog_agent_remap_blackhole_acks -189.05KiB/CPU-s -0.58 100.00% 31.9MiB/CPU-s 424.79KiB/CPU-s 5.48KiB/CPU-s 0.0 0.013003 31.71MiB/CPU-s 703.1KiB/CPU-s 9.08KiB/CPU-s 0.0 0.021648 False False
http_text_to_http_json -297.69KiB/CPU-s -1.23 100.00% 23.58MiB/CPU-s 507.76KiB/CPU-s 6.56KiB/CPU-s 0.0 0.021023 23.29MiB/CPU-s 518.2KiB/CPU-s 6.69KiB/CPU-s 0.0 0.021723 False False
datadog_agent_remap_blackhole -694.6KiB/CPU-s -2.18 100.00% 31.14MiB/CPU-s 884.47KiB/CPU-s 11.42KiB/CPU-s 0.0 0.027738 30.46MiB/CPU-s 1.18MiB/CPU-s 15.64KiB/CPU-s 0.0 0.038846 False False
syslog_log2metric_humio_metrics -168.03KiB/CPU-s -2.75 100.00% 5.97MiB/CPU-s 151.11KiB/CPU-s 1.95KiB/CPU-s 0.0 0.02473 5.8MiB/CPU-s 341.08KiB/CPU-s 4.4KiB/CPU-s 0.0 0.057399 False False
syslog_regex_logs2metric_ddmetrics -126.6KiB/CPU-s -3.27 100.00% 3.78MiB/CPU-s 441.95KiB/CPU-s 5.7KiB/CPU-s 0.0 0.114079 3.66MiB/CPU-s 425.53KiB/CPU-s 5.49KiB/CPU-s 0.0 0.113551 True False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to store sub-second precision in ClickHouse
3 participants