fix(splunk_hec source): add assert_source_error to error path test #14764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Wakely <[email protected]>
github-actions
bot
added
the
domain: sources
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
spencergilbert
approved these changes
Oct 7, 2022
neuronull
approved these changes
Oct 7, 2022
jszwedko
pushed a commit
that referenced
this pull request
Oct 27, 2022
…14764) Assert source error. Signed-off-by: Stephen Wakely <[email protected]> Signed-off-by: Stephen Wakely <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14505
This adds a call to
assert_source_errorin the unhappy path test to ensure the correct error events are emitted.Fortunately the test passed, so no further changes were needed.
Signed-off-by: Stephen Wakely [email protected]