Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcp_chronicle sink): add run_and_assert_sink_error to unhappy path test #14596

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

StephenWakely
Copy link
Contributor

Ref #14595

This adds a run_and_assert_sink_error call to the unhappy path integration test. This highlighted the issue that error returns from chronicle were not emitting an error. So this also fixes that.

As an added bonus it seems the chronicle integration tests weren't included in the list of tests, so this PR also adds them to the Makefile.

Signed-off-by: Stephen Wakely [email protected]

@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit d5777ca
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/6332e74703b284000855c831
😎 Deploy Preview https://deploy-preview-14596--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added domain: ci Anything related to Vector's CI environment domain: sinks Anything related to the Vector's sinks labels Sep 27, 2022
@StephenWakely StephenWakely merged commit fd5ba44 into master Sep 27, 2022
@StephenWakely StephenWakely deleted the stephen/chronicle_error_test branch September 27, 2022 13:53
@github-actions
Copy link

Soak Test Results

Baseline: f38e3c3
Comparison: d5777ca
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_log2metric_splunk_hec_metrics 361.93KiB 2.11 100.00% 16.74MiB 993.37KiB 20.24KiB 0 0.0579472 17.09MiB 807.41KiB 16.44KiB 0 0.0461253 False False
datadog_agent_remap_blackhole_acks 771.65KiB 1.25 100.00% 60.11MiB 4.38MiB 91.27KiB 0 0.0729341 60.86MiB 2.79MiB 58.41KiB 0 0.045855 False False
datadog_agent_remap_blackhole 483.03KiB 0.8 100.00% 58.91MiB 3.83MiB 79.72KiB 0 0.0649318 59.38MiB 2.91MiB 60.8KiB 0 0.0490665 False False
syslog_log2metric_humio_metrics 73.38KiB 0.56 100.00% 12.69MiB 326.67KiB 6.66KiB 0 0.0251353 12.76MiB 478.54KiB 9.75KiB 0 0.0366136 False False
syslog_regex_logs2metric_ddmetrics 28.76KiB 0.23 97.07% 12.07MiB 463.46KiB 9.44KiB 0 0.0374769 12.1MiB 451.84KiB 9.21KiB 0 0.0364525 False False
splunk_hec_indexer_ack_blackhole 23.5KiB 0.1 61.89% 23.73MiB 974.4KiB 19.81KiB 0 0.0400839 23.76MiB 889.29KiB 18.1KiB 0 0.0365477 False False
splunk_hec_to_splunk_hec_logs_noack 24.63KiB 0.1 95.21% 23.81MiB 510.12KiB 10.42KiB 0 0.0209137 23.84MiB 333.56KiB 6.81KiB 0 0.0136613 False False
syslog_splunk_hec_logs 4.18KiB 0.03 16.02% 16.04MiB 789.89KiB 16.06KiB 0 0.0480715 16.05MiB 637.62KiB 12.99KiB 0 0.0387948 False False
enterprise_http_to_http 421.26B 0 4.50% 23.85MiB 253.36KiB 5.17KiB 0 0.0103738 23.85MiB 251.24KiB 5.14KiB 0 0.0102869 False False
splunk_hec_to_splunk_hec_logs_acks -1.32KiB -0.01 3.86% 23.76MiB 936.01KiB 19.04KiB 0 0.0384663 23.76MiB 955.67KiB 19.44KiB 0 0.0392764 False False
file_to_blackhole -102.11KiB -0.1 67.34% 95.34MiB 3.04MiB 62.95KiB 0 0.0318445 95.24MiB 3.99MiB 82.88KiB 0 0.0418645 False False
http_to_http_json -37.66KiB -0.15 99.56% 23.84MiB 345.05KiB 7.04KiB 0 0.0141296 23.81MiB 547.49KiB 11.17KiB 0 0.0224539 False False
fluent_elasticsearch -173.92KiB -0.21 100.00% 79.47MiB 53.62KiB 1.08KiB 0 0.000658789 79.3MiB 1.46MiB 29.96KiB 0 0.0183682 False False
syslog_humio_logs -44.34KiB -0.27 100.00% 16.0MiB 258.7KiB 5.28KiB 0 0.0157872 15.96MiB 221.54KiB 4.54KiB 0 0.0135561 False False
http_to_http_noack -112.74KiB -0.46 100.00% 23.84MiB 405.62KiB 8.3KiB 0 0.0166142 23.73MiB 1.19MiB 24.86KiB 0 0.050265 False False
syslog_loki -79.17KiB -0.54 100.00% 14.35MiB 314.5KiB 6.44KiB 0 0.0213958 14.27MiB 711.98KiB 14.47KiB 0 0.0486994 False False
http_to_http_acks -124.42KiB -0.7 39.75% 17.4MiB 8.15MiB 170.42KiB 0 0.468402 17.28MiB 8.02MiB 167.39KiB 0 0.463877 True True
http_pipelines_no_grok_blackhole -88.8KiB -0.8 99.99% 10.81MiB 342.45KiB 6.99KiB 0 0.0309285 10.72MiB 1.04MiB 21.59KiB 0 0.0966366 False False
http_pipelines_blackhole -15.3KiB -0.9 100.00% 1.65MiB 20.57KiB 430.59B 0 0.0121391 1.64MiB 90.24KiB 1.84KiB 0 0.0537404 False False
datadog_agent_remap_datadog_logs -614.69KiB -0.97 100.00% 61.57MiB 262.8KiB 5.38KiB 0 0.00416735 60.97MiB 3.86MiB 80.46KiB 0 0.0633308 False False
splunk_hec_route_s3 -193.62KiB -1 99.71% 18.88MiB 2.22MiB 46.21KiB 0 0.117492 18.7MiB 2.19MiB 45.71KiB 0 0.116858 False False
datadog_agent_remap_datadog_logs_acks -668.24KiB -1.09 100.00% 59.68MiB 4.7MiB 98.2KiB 0 0.0787769 59.02MiB 5.24MiB 109.08KiB 0 0.0887645 False False
socket_to_socket_blackhole -624.98KiB -2.55 100.00% 23.91MiB 448.21KiB 9.15KiB 0 0.0183018 23.3MiB 256.77KiB 5.24KiB 0 0.0107595 False False
http_text_to_http_json -1.33MiB -3.33 100.00% 39.97MiB 688.54KiB 14.05KiB 0 0.0168197 38.64MiB 835.82KiB 17.06KiB 0 0.0211203 False False
http_pipelines_blackhole_acks -40.21KiB -3.36 100.00% 1.17MiB 164.0KiB 3.34KiB 0 0.136883 1.13MiB 153.12KiB 3.12KiB 0 0.132238 False False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants