Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authentication in the fluent source #7532

Open
jszwedko opened this issue May 20, 2021 · 4 comments
Open

Support authentication in the fluent source #7532

jszwedko opened this issue May 20, 2021 · 4 comments
Labels
source: fluent Anything `fluent` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@jszwedko
Copy link
Member

As part of #419 we are adding a fluent source, but chose not to include authentication in the initial implementation due to the additional work it will require. This issue represents that work.

Please leave a 👍 or comment below if you would find this support useful.

@jszwedko jszwedko added the type: enhancement A value-adding code change that enhances its existing functionality. label May 20, 2021
jszwedko added a commit that referenced this issue Jun 7, 2021
New source for consuming data from fluentd and fluent-bit via their native [forward protocol](https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v1).

This implementation supports the various formats that the specification allows for but does not implement the authentication protocol (#7532) or the acknowledgment (#7533) parts of the protocol. I left these for follow-up based on user demand given it is a significant divergence from the existing TCP source which just consumes data rather than request/response.

Aside from the source implementation, the other significant change here is extraction of some bits of the `docker_logs` source into a shared `docker` module to use it in the `fluent` source integration tests. The integration tests are more similar to the `docker_logs` integration tests than the other component integration tests in that they each run a separate docker container rather than just standing up one long running one before running the tests as these tests need to run fluentd and fluent-bit with different configurations.

Apologies, I didn't break up the early commits into logical changes, but hopefully the PR itself is reviewable.

Closes #419 

Signed-off-by: Jesse Szwedko <[email protected]>
@AntonSmolkov
Copy link

AntonSmolkov commented Jun 29, 2021

@jszwedko Hi! Also, what about compression btw? Is it supported, will be supported?

Cause sending side supports it - https://docs.fluentd.org/output/forward#how-to-enable-gzip-compression

Update:
Nevermind, i've found the code and see it is gonna be supported. Thx)

@spencergilbert
Copy link
Contributor

@jszwedko Hi! Also, what about compression btw? Is it supported, will be supported?

Cause sending side supports it - https://docs.fluentd.org/output/forward#how-to-enable-gzip-compression

Hey! We support https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v1#compressedpackedforward-mode

See: https://github.com/timberio/vector/blob/master/src/sources/fluent.rs#L346-L354

@jszwedko jszwedko added the source: fluent Anything `fluent` source related label Dec 28, 2022
@hatrena
Copy link

hatrena commented Mar 19, 2024

@jszwedko Thanks a lot for supporting the fluent source in Vector. Is there any rough estimation on supporting authentication in the fluent source?

@jszwedko
Copy link
Member Author

No estimate on timeline unfortunately. We'd be happy to see a contribution though if someone is motivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: fluent Anything `fluent` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

4 participants