Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRD for Vector's high-level performance goals, methods to accomplish and maintain them #6531

Closed
blt opened this issue Feb 22, 2021 · 1 comment · Fixed by #6549 or #6601
Closed

PRD for Vector's high-level performance goals, methods to accomplish and maintain them #6531

blt opened this issue Feb 22, 2021 · 1 comment · Fixed by #6549 or #6601
Assignees
Labels
domain: performance Anything related to Vector's performance needs: rfc Needs an RFC before work can begin. type: task Generic non-code related tasks

Comments

@blt
Copy link
Contributor

blt commented Feb 22, 2021

We have ongoing benchmark work being done in two main areas. The first is criterion based benchmarks in the codebase and the second is a "nightly" approach in vector-test-harness. A third method is also present in the team: ad hoc local eyeballing. With the context of the Vector project having changed we want to get more rigorous about this kind of work to avoid regressions but also to consistently improve.

The Problem

While we have discussed as a team what our performance goals are and how we'll approach them we have not formalized the process, nor do we have a set of resources for addressing performance issues. This RFC will describe the task at hand, enumerate our goals, describe ongoing work and set out adjustments.

Goals

This RFC intends to set forward a definitive list of our optimization aims and our initial performance goals. As well, it will set out the initial means for achieving and maintaining these.

Non-Goals

This RFC does not intend to set forward a team process. As of this writing the team is busy adding criterion benchmarks to the vector code base. Questions of coverage guidelines are outside the scope of this RFC. How do deal with introduced performance regressions are, likewise, out of scope beyond notions of how debugging and correction will work. This RFC intends to set out a foundation to iterate on together, not an unchangeable artifact.

Related discussions

@blt blt added type: task Generic non-code related tasks needs: rfc Needs an RFC before work can begin. domain: performance Anything related to Vector's performance labels Feb 22, 2021
@binarylogic binarylogic assigned blt and unassigned binarylogic Feb 22, 2021
@binarylogic binarylogic changed the title Identify Vector's high-level performance goals, methods to accomplish and maintain them PRD for Vector's high-level performance goals, methods to accomplish and maintain them Feb 22, 2021
@binarylogic binarylogic modified the milestone: 2021-02-22 - Scottish Deerhound Feb 22, 2021
@blt blt closed this as completed in #6549 Mar 1, 2021
@blt
Copy link
Contributor Author

blt commented Mar 1, 2021

Re-opening. As @binarylogic noted the RFC from #6549 lacks a plan of action section.

@blt blt reopened this Mar 1, 2021
@blt blt closed this as completed in #6601 Mar 4, 2021
blt added a commit that referenced this issue Mar 4, 2021
* Introduce a Plan of Action into RFC 6531

This commit introduces a plan of action section into RFC 6531, which I
previously did not include. This PR closes #6531.

Signed-off-by: Brian L. Troutwine <[email protected]>

* spelling mistakes

Signed-off-by: Brian L. Troutwine <[email protected]>

* clarify wording

Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: performance Anything related to Vector's performance needs: rfc Needs an RFC before work can begin. type: task Generic non-code related tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants