Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require the data_dir option for the file source and default it to the global data_dir #644

Closed
3 tasks
binarylogic opened this issue Jul 15, 2019 · 1 comment · Fixed by #673
Closed
3 tasks

Require the data_dir option for the file source and default it to the global data_dir #644

binarylogic opened this issue Jul 15, 2019 · 1 comment · Fixed by #673
Labels
meta: good first issue Anything that is good for new contributors. needs: approval Needs review & approval before work can begin. source: file Anything `file` source related type: bug A code related bug.
Milestone
Improve the file ...

Comments

@binarylogic
Copy link
Contributor

Currently, the file source requires a data_dir for checkpointing, yet this requirement is not enforced when Vector is started. You can see here that the data_dir option defaults to an empty path. This should not be allowed since an explicit data directory should be specified to store the checkpoint positions.

Requirements

  • Default the file source data_dir option to the global data_dir
  • Exit on start if the file source data_dir option is empty.
  • Allow the user to pass a data_dir option in the file source itself to override the global data_dir.
@binarylogic binarylogic added type: bug A code related bug. source: file Anything `file` source related meta: good first issue Anything that is good for new contributors. needs: approval Needs review & approval before work can begin. labels Jul 15, 2019
seeekr added a commit to seeekr/vector that referenced this issue Jul 22, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
9a650cb 
…#644)

also makes global options (currently only data_dir) available to all
sources via SourceConfig::build()
seeekr added a commit to seeekr/vector that referenced this issue Jul 22, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
9b59122 
…#644)

also makes global options (currently only data_dir) available to all
sources via SourceConfig::build()

Signed-off-by: Denis Andrejew <[email protected]>
@seeekr seeekr mentioned this issue Jul 22, 2019
Merged
3 tasks
seeekr added a commit to seeekr/vector that referenced this issue Jul 22, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
333e857 
…#644)

also makes global options (currently only data_dir) available to all
sources via SourceConfig::build()

Signed-off-by: Denis Andrejew <[email protected]>
@seeekr
Copy link
Contributor

seeekr commented Jul 22, 2019

#673 should solve this and tick all 3 boxes.

seeekr added a commit to seeekr/vector that referenced this issue Jul 22, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
9a60ba6 
…#644)

also makes global options (currently only data_dir) available to all
sources via SourceConfig::build()

Signed-off-by: Denis Andrejew <[email protected]>
seeekr added a commit to seeekr/vector that referenced this issue Jul 29, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
b212512 
…#644)

also makes global options (currently only data_dir) available to all
sources via SourceConfig::build()

Signed-off-by: Denis Andrejew <[email protected]>
seeekr added a commit to seeekr/vector that referenced this issue Jul 29, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
c9f7f22 
…#644)

also makes source name and global options (currently only data_dir)
available to all sources via SourceConfig::build()

Signed-off-by: Denis Andrejew <[email protected]>
seeekr added a commit to seeekr/vector that referenced this issue Jul 29, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
e3817ef 
…#644)

also makes source name and global options (currently only data_dir)
available to all sources via SourceConfig::build()

Signed-off-by: Denis Andrejew <[email protected]>
@bruceg bruceg mentioned this issue Jul 30, 2019
Closed
seeekr added a commit to seeekr/vector that referenced this issue Jul 31, 2019
@seeekr
feat(sources/file): fall back to global data_dir option (vectordotdev…
e1ea7cb 
…#644)

also makes source name and global options (currently only data_dir)
available to all sources via SourceConfig::build()

Signed-off-by: Denis Andrejew <[email protected]>
binarylogic pushed a commit that referenced this issue Aug 6, 2019
@seeekr @binarylogic
feat(sources/file): fall back to global data_dir option (#644) (#673)
e190e96 
Signed-off-by: Denis Andrejew <[email protected]>
@binarylogic binarylogic added this to the Improve the file source milestone Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta: good first issue Anything that is good for new contributors. needs: approval Needs review & approval before work can begin. source: file Anything `file` source related type: bug A code related bug.
Projects
None yet
Milestone
Improve the file source
Development

Successfully merging a pull request may close this issue.

feat(sources/file): fall back to global data_dir option (#644) seeekr/vector
2 participants
@seeekr @binarylogic