Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric model website documentation shows namespace as required #21430

Closed
jorgehermo9 opened this issue Oct 5, 2024 · 1 comment · Fixed by #21439
Closed

Metric model website documentation shows namespace as required #21430

jorgehermo9 opened this issue Oct 5, 2024 · 1 comment · Fixed by #21439
Labels
domain: external docs Anything related to Vector's external, public documentation domain: metrics Anything related to Vector's metrics events type: bug A code related bug.

Comments

@jorgehermo9
Copy link
Contributor

jorgehermo9 commented Oct 5, 2024

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

In the metric model documentation the namespace field is depicted as required
image

But in the code, it is optional

pub namespace: Option<String>,
and we can create non-namespaced metric's (as done in #21429 with the log_to_metric transform)

Is this a documentation bug or is it intended?

Configuration

No response

Version

vector 0.41.1 (x86_64-unknown-linux-gnu)

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

@jorgehermo9 jorgehermo9 added the type: bug A code related bug. label Oct 5, 2024
@jszwedko
Copy link
Member

jszwedko commented Oct 7, 2024

Thanks @jorgehermo9 ! I think that is a documentation bug.

@jszwedko jszwedko added domain: external docs Anything related to Vector's external, public documentation domain: metrics Anything related to Vector's metrics events labels Oct 7, 2024
jszwedko added a commit that referenced this issue Oct 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: metrics Anything related to Vector's metrics events type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants