Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEBIAN/conffiles has two trailing newlines which prevent Uyuni/SUSE Manager from importing Vector deb repo #19008

Open
ypid-work opened this issue Nov 1, 2023 · 3 comments · Fixed by #19009
Open

DEBIAN/conffiles has two trailing newlines which prevent Uyuni/SUSE Manager from importing Vector deb repo #19008

ypid-work opened this issue Nov 1, 2023 · 3 comments · Fixed by #19009
Labels
type: bug A code related bug.

Comments

@ypid-work
Copy link

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

#18439 caused a regression. Thus #18726 has reverted the regression but now breaks DEBIAN/conffiles for Uyuni/SUSE Manager again.

It appears that cargo-deb doesn't actually leverage dh_installdeb so we don't get this for free. This will break #18439 again but that will be fixed once cargo-deb releases kornelski/cargo-deb@cd377b2.

Ref: #18726

2.0.0 of cargo-deb has since been released so I suggest to update to it.

Configuration

No response

Version

vector 0.34.0 (x86_64-unknown-linux-gnu 5e9dd1d 2023-11-01 04:04:40.299837243)

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response
@ypid-work ypid-work added the type: bug A code related bug. label Nov 1, 2023
@jszwedko
Copy link
Member

jszwedko commented Nov 1, 2023

Thanks for filing this @ypid-work . I had meant to re-open #18439 once the revert was merged. It looks like the cargo-deb change may have been released so we should be able to fix this again in the next release.

jszwedko added a commit that referenced this issue Nov 1, 2023
@jszwedko
fix(releasing): Update cargo-deb
da6058a 
To include fix to not have empty newlines in conffiles.

Fixes: #19008

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko mentioned this issue Nov 1, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 2, 2023
@jszwedko
fix(releasing): Update cargo-deb (#19009)
88194e7 
To include fix to not have empty newlines in conffiles.

Fixes: #19008

Signed-off-by: Jesse Szwedko <[email protected]>
@ypid-work
Copy link
Author

Problem is not fixed sadly with neither:

Can you reopen and check?

@jszwedko
Copy link
Member

jszwedko commented Dec 2, 2023 •
edited
Loading

I verified this is still an issue. This is very strange since my reproduction of the bug with cargo-deb is fixed with 2.0.0 which I confirmed is what the v0.34.1 release was built with. I'm not sure what's going on then.

@jszwedko jszwedko reopened this Dec 2, 2023
@jszwedko jszwedko changed the title Upgrade to cargo-deb 2.0.0 to fix deb packaging: Two trailing \n in DEBIAN/conffiles prevent Uyuni/SUSE Manager from importing Vector deb repo DEBIAN/conffiles has two trailing newlines which prevent Uyuni/SUSE Manager from importing Vector deb repo Dec 2, 2023
AndrooTheChen pushed a commit to discord/vector that referenced this issue Sep 23, 2024
@jszwedko @AndrooTheChen
fix(releasing): Update cargo-deb (vectordotdev#19009)
5feb2fe 
To include fix to not have empty newlines in conffiles.

Fixes: vectordotdev#19008

Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A code related bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(releasing): Update cargo-deb vectordotdev/vector
2 participants
@jszwedko @ypid-work