Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Want to adjust graceful shutdown time. #12831

Closed
ojh3636 opened this issue May 24, 2022 · 3 comments
Closed

Want to adjust graceful shutdown time. #12831

ojh3636 opened this issue May 24, 2022 · 3 comments
Labels
domain: shutdown Anything related to the shutdown of Vector type: feature A value-adding code addition that introduce new functionality.

Comments

@ojh3636
Copy link

ojh3636 commented May 24, 2022

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

The vector waits in-progress event's only for 1minutes. Please consider global options to adjust this time.

vector/src/topology/running.rs

Line 120 in ae94c8c

let deadline = Instant::now() + Duration::from_secs(60);

Use Cases

Adjust the shutdown wait time to prevent from data loss. Some situation (ex> es circuit breaking) the processing time is huge than normal situation. In that case, vector just loss all data when restart or stop the instance.

Attempted Solutions

No response

Proposal

No response

References

No response

Version

No response
@ojh3636 ojh3636 added the type: feature A value-adding code addition that introduce new functionality. label May 24, 2022
@jszwedko
Copy link
Member

Hi @ojh3636 ! Thanks for opening this. I agree. We have #9042 tracking removing this value (and possibly making it configurable), so I'll close this as a duplicate but feel free to leave any additional thoughts there!

@jszwedko jszwedko reopened this May 22, 2023
@jszwedko
Copy link
Member

Re-opening this to track making the shutdown configurable, separate from making it disablable (#9042).

@jszwedko jszwedko added the domain: shutdown Anything related to the shutdown of Vector label May 22, 2023
@DominicBurkart DominicBurkart mentioned this issue May 24, 2023
Merged
DominicBurkart added a commit that referenced this issue Jun 1, 2023
@DominicBurkart @bruceg
feat(configurable shutdown duration): make shutdown duration configur…
23ed0e3 
…able (#17479)

We want to make the graceful shutdown period configurable instead of
hardcoding it to sixty seconds.

Issues:
#9042 Remove 60s hard
cutoff period for graceful shutdowns
#12831 Want to adjust
graceful shutdown time

This is my first PR in vector, not sure if this is the correct approach:
- are the ergonomics (-1 for no timeout, 0+ for timeout durations) good?
- any test recommendations beyond manual testing?

---------

Co-authored-by: Bruce Guenter <[email protected]>
@DominicBurkart DominicBurkart mentioned this issue Jun 23, 2023
Merged
@jszwedko
Copy link
Member

jszwedko commented Aug 2, 2023

Closed by #17479

@jszwedko jszwedko closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: shutdown Anything related to the shutdown of Vector type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jszwedko @ojh3636